search

esl / MongooseIM

MongooseIM is Erlang Solutions' robust, scalable and efficient XMPP server, aimed at large installations. Specifically designed for enterprise purposes, it is fault-tolerant and can utilise the resources of multiple clustered machines.
Other
1.64k stars 422 forks source link

Change config in muclight was replacing old config. #4175

Closed jaspreet-android closed 5 months ago

jaspreet-android commented 5 months ago

This PR addresses #4173

Proposed changes include: This change will fix the config in muc-light which was replacing the old config to the default value.

arcusfelis commented 5 months ago

Hi, thanks for the pull request. We would have to have tests for the fix inside muc_light suite in the big tests directory: https://github.com/esl/MongooseIM/blob/master/big_tests/tests/graphql_muc_light_SUITE.erl

jaspreet-android commented 5 months ago

Hi, thanks for the pull request. We would have to have tests for the fix inside muc_light suite in the big tests directory: https://github.com/esl/MongooseIM/blob/master/big_tests/tests/graphql_muc_light_SUITE.erl

Screenshot 2023-11-21 at 9 01 23 PM

I think test is passing on my side.

NelsonVides commented 5 months ago

@jaspreet-android I just tested locally, and muc_light_SUITE (not graphql_muc_light_SUITE as you pasted in your screenshot), fails in my machine. This needs fixing, old tests can't fail and new functionality must come with new tests.

jaspreet-android commented 5 months ago

This is fixed as in master, so I am closing it.