search

esl / MongooseIM

MongooseIM is Erlang Solutions' robust, scalable and efficient XMPP server, aimed at large installations. Specifically designed for enterprise purposes, it is fault-tolerant and can utilise the resources of multiple clustered machines.
Other
1.64k stars 422 forks source link

Fix muc_light_rooms.id key deifinition on MariaDB #4195

Closed arcusfelis closed 5 months ago

arcusfelis commented 5 months ago

Fixes error with MariaDB when applying schema:

ERROR 1901 (HY000) at line 319: Function or expression 'AUTO_INCREMENT' cannot be used in the USING HASH

This PR addresses MIM-2135:

Proposed changes include:

mongoose-im commented 5 months ago

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root/ big OK: 370 / Failed: 0 / User-skipped: 40 / Auto-skipped: 0

small_tests_25 / small_tests / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root / small

small_tests_26 / small_tests / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root / small

small_tests_26_arm64 / small_tests / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root / small

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root/ big OK: 4239 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root/ big OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0

ldap_mnesia_26 / ldap_mnesia / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root/ big OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root/ big OK: 4239 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

internal_mnesia_26 / internal_mnesia / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root/ big OK: 2408 / Failed: 0 / User-skipped: 707 / Auto-skipped: 0

dynamic_domains_mysql_redis_26 / mysql_redis / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root/ big OK: 4206 / Failed: 0 / User-skipped: 135 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root/ big OK: 4236 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

pgsql_cets_26 / pgsql_cets / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root/ big OK: 4283 / Failed: 0 / User-skipped: 110 / Auto-skipped: 0

pgsql_mnesia_26 / pgsql_mnesia / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root/ big OK: 4628 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root/ big OK: 4628 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0

mysql_redis_26 / mysql_redis / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root/ big OK: 4607 / Failed: 0 / User-skipped: 130 / Auto-skipped: 0

mssql_mnesia_26 / odbc_mssql_mnesia / 1e3f953bbd471409ace3bc14bb813384645c04c7 Reports root/ big OK: 4625 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:end_per_group ```erlang {error, {{unregistering_failed, {amount,1}, {unregistered_items, [{{<<"_domain_admin_create_room_no_permission_1090">>, [{escalus_event_mgr,<0.24723.0>}, {tc_name,domain_admin_create_room_no_permission}, {escalus_cleaner,<0.24722.0>}, {watchdog,<0.24721.0>}, {muc_light_host,<<"muclight.localhost">>}, {secondary_muc_light_host,<<"muclight.localhost.bis">>}, {protocol,http}, {domain_admin,{<<"admin@localhost">>,<<"f710f8daa1288125">>}}, {schema_endpoint,domain_admin}, {{ejabberd_cwd,mongooseim@localhost}, "/home/circleci/project/_build/mim1/rel/mongooseim"}, {preset,"odbc_mssql_mnesia"}, {mim_data_dir, "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"}, {tc_logfile, "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4195/204005/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40e84896a28784.2023-12-20_12.31.47/big_tests.tests.graphql_muc_light_SUITE.logs/run.2023-12-20_12.36.05/graphql_muc_light_suite.domain_admin_create_room_no_permission.html"}, {tc_group_properties,[{name,domain_admin_muc_light}]}, {tc_group_path,[[{name,domain_admin}]]}, {data_dir, "/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"}, {priv_dir, "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4195/204005/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40e84896a28784.2023-12-20_12.31.47/big_tests.tests.graphql_muc_light_SUITE.logs/run.2023-12-20_12.36.05/log_private/"}, {{saved_modules,mongooseim@localhost,<<"localhost">>}, #{mod_vcard =... ``` [Report log](https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4195/204005/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40e84896a28784.2023-12-20_12.31.47/big_tests.tests.graphql_muc_light_SUITE.logs/run.2023-12-20_12.36.05/graphql_muc_light_suite.end_per_group.59266.html)
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b29ab06) 84.29% compared to head (1e3f953) 84.31%. Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4195 +/- ## ========================================== + Coverage 84.29% 84.31% +0.02% ========================================== Files 551 551 Lines 33473 33473 ========================================== + Hits 28215 28222 +7 + Misses 5258 5251 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.