Closed chrzaszcz closed 4 months ago
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root/ big OK: 370 / Failed: 0 / User-skipped: 40 / Auto-skipped: 0
small_tests_25 / small_tests / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root / small
small_tests_26 / small_tests / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root / small
small_tests_26_arm64 / small_tests / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root / small
dynamic_domains_mysql_redis_26 / mysql_redis / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root/ big OK: 4208 / Failed: 1 / User-skipped: 135 / Auto-skipped: 0
ldap_mnesia_26 / ldap_mnesia / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root/ big OK: 2270 / Failed: 1 / User-skipped: 847 / Auto-skipped: 0
ldap_mnesia_25 / ldap_mnesia / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root/ big OK: 2269 / Failed: 2 / User-skipped: 847 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root/ big OK: 4241 / Failed: 1 / User-skipped: 102 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root/ big OK: 4241 / Failed: 1 / User-skipped: 102 / Auto-skipped: 0
internal_mnesia_26 / internal_mnesia / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root/ big OK: 2409 / Failed: 2 / User-skipped: 707 / Auto-skipped: 0
pgsql_cets_26 / pgsql_cets / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root/ big OK: 4285 / Failed: 1 / User-skipped: 110 / Auto-skipped: 0
dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root/ big OK: 4237 / Failed: 2 / User-skipped: 105 / Auto-skipped: 0
pgsql_mnesia_25 / pgsql_mnesia / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root/ big OK: 4630 / Failed: 1 / User-skipped: 109 / Auto-skipped: 0
mysql_redis_26 / mysql_redis / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root/ big OK: 4608 / Failed: 2 / User-skipped: 130 / Auto-skipped: 0
pgsql_mnesia_26 / pgsql_mnesia / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root/ big OK: 4630 / Failed: 1 / User-skipped: 109 / Auto-skipped: 0
mssql_mnesia_26 / odbc_mssql_mnesia / ba8a7a33b5e364b74623b633ffaabbf15e2581a4 Reports root/ big OK: 4626 / Failed: 2 / User-skipped: 112 / Auto-skipped: 0
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
dc7cef6
) 84.29% compared to head (309fb47
) 84.33%.
Files | Patch % | Lines |
---|---|---|
src/mod_websockets.erl | 80.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root/ big OK: 370 / Failed: 0 / User-skipped: 40 / Auto-skipped: 0
small_tests_25 / small_tests / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root / small
small_tests_26 / small_tests / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root / small
small_tests_26_arm64 / small_tests / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root / small
ldap_mnesia_25 / ldap_mnesia / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root/ big OK: 2271 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root/ big OK: 4242 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0
dynamic_domains_mysql_redis_26 / mysql_redis / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root/ big OK: 4209 / Failed: 0 / User-skipped: 135 / Auto-skipped: 0
ldap_mnesia_26 / ldap_mnesia / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root/ big OK: 2271 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root/ big OK: 4242 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0
internal_mnesia_26 / internal_mnesia / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root/ big OK: 2411 / Failed: 0 / User-skipped: 707 / Auto-skipped: 0
pgsql_mnesia_25 / pgsql_mnesia / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root/ big OK: 4631 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0
dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root/ big OK: 4239 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
pgsql_cets_26 / pgsql_cets / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root/ big OK: 4286 / Failed: 0 / User-skipped: 110 / Auto-skipped: 0
mysql_redis_26 / mysql_redis / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root/ big OK: 4610 / Failed: 0 / User-skipped: 130 / Auto-skipped: 0
pgsql_mnesia_26 / pgsql_mnesia / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root/ big OK: 4631 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0
mssql_mnesia_26 / odbc_mssql_mnesia / 486f6045f63d427ae7de12b47b304d4576feb930 Reports root/ big OK: 4628 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 370 / Failed: 0 / User-skipped: 40 / Auto-skipped: 0
small_tests_25 / small_tests / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root / small
small_tests_26 / small_tests / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root / small
small_tests_26_arm64 / small_tests / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root / small
ldap_mnesia_25 / ldap_mnesia / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 2271 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0
dynamic_domains_mysql_redis_26 / mysql_redis / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 4209 / Failed: 0 / User-skipped: 135 / Auto-skipped: 0
ldap_mnesia_26 / ldap_mnesia / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 2271 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 4241 / Failed: 1 / User-skipped: 102 / Auto-skipped: 0
internal_mnesia_26 / internal_mnesia / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 2411 / Failed: 0 / User-skipped: 707 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 4242 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0
dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 4239 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
pgsql_mnesia_25 / pgsql_mnesia / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 4631 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0
pgsql_cets_26 / pgsql_cets / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 4286 / Failed: 0 / User-skipped: 110 / Auto-skipped: 0
pgsql_mnesia_26 / pgsql_mnesia / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 4631 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0
mysql_redis_26 / mysql_redis / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 4610 / Failed: 0 / User-skipped: 130 / Auto-skipped: 0
mssql_mnesia_26 / odbc_mssql_mnesia / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 4628 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 309fb47eb01ecd1134a74f15884848de232022c2 Reports root/ big OK: 4242 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0
The limit worked partially - only if the input was chunked, and not working properly for small limits. For websockets it wasn't working at all as reported in https://github.com/esl/MongooseIM/issues/4193.
The main fix is in the C++ code in
exml
: https://github.com/esl/exml/pull/68 This PR also uses a fix forescalus
- I discovered an issue when adding a new test: https://github.com/esl/escalus/pull/261These two PR's should be merged first. Then we could release them in hex, and update this PR.
Note: Latest escalus does not work with big tests anymore after merging https://github.com/esl/escalus/pull/259, and this needs a fix before releasing the hex package.
Recommended to do in the future:
stream
tag name verification in both regular C2S and websockets.