Instrument/metric improvements

chrzaszcz commented 1 month ago

This PR groups several improvements of metric handling in mongoose_instrument.

Changes:

Added support for the all_metrics_are_global option in instrumentation.exometer.
Event handler failures are now caught and logged to isolate them from the instrumented code.
Already existing metrics are reset in set_up.
Prometheus counters are initialised with zero to avoid the issue with initial rate calculation in metric graphs.
- Histograms are not initialised like this, because if there is no data, quantiles cannot be calculated, and zeroes would be technically incorrect.
Optional start/0 and stop/0 in the mongoose_instrument behaviour.
Prometheus metrics use string for keys to avoid list_to_atom.
Removed dependency on mongoose_metrics.

mongoose-im commented 1 month ago

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root/ big OK: 435 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0

small_tests_26 / small_tests / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root / small

small_tests_25 / small_tests / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root / small

small_tests_26_arm64 / small_tests / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root / small

ldap_mnesia_25 / ldap_mnesia / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root/ big OK: 2275 / Failed: 0 / User-skipped: 895 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root/ big OK: 4522 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

dynamic_domains_mysql_redis_26 / mysql_redis / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root/ big OK: 4489 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0

ldap_mnesia_26 / ldap_mnesia / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root/ big OK: 2275 / Failed: 0 / User-skipped: 895 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root/ big OK: 4522 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

internal_mnesia_26 / internal_mnesia / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root/ big OK: 2415 / Failed: 0 / User-skipped: 755 / Auto-skipped: 0

pgsql_cets_26 / pgsql_cets / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root/ big OK: 4439 / Failed: 0 / User-skipped: 174 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root/ big OK: 4519 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0

mysql_redis_26 / mysql_redis / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root/ big OK: 4889 / Failed: 1 / User-skipped: 133 / Auto-skipped: 0

carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons

```erlang {error, {{badmatch, [{xmlel,<<"message">>, [{<<"from">>, <<"alice_dropped_client_doesnt_create_duplicate_carbons_586@localhost">>}, {<<"to">>, <<"alice_dropped_client_doesnt_create_duplicate_carbons_586@localhost/res2">>}, {<<"xmlns">>,<<"jabber:client">>}, {<<"type">>,<<"chat">>}], [{xmlel,<<"sent">>, [{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}], [{xmlel,<<"forwarded">>, [{<<"xmlns">>,<<"urn:xmpp:forward:0">>}], [{xmlel,<<"message">>, [{<<"from">>, <<"alice_dropped_client_doesnt_create_duplicate_carbons_586@localhost/res1">>}, {<<"type">>,<<"chat">>}, {<<"to">>, <<"bob_dropped_client_doesnt_create_duplicate_carbons_586@localhost/res1">>}, {<<"xmlns">>,<<"jabber:client">>}], [{xmlel,<<"body">>,[], [{xmlcdata, <<"And pious action">>}]}]}]}]}]}]}, [{carboncopy_SUITE, '-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4, [{file, "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"}, {line,189}]}, {escalus_story,story,4, [{file, "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"}, {line,72}]}, {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]}, {test_server,run_test_case_eval1,6, [{file,"test_serv... ``` [Report log](https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4249/213239/mysql_redis.26.1.2-amd64/big/ct_run.test%407c959de2aa09.2024-03-22_15.51.12/big_tests.tests.carboncopy_SUITE.logs/run.2024-03-22_15.51.57/carboncopy_suite.dropped_client_doesnt_create_duplicate_carbons.21122.html)

pgsql_mnesia_25 / pgsql_mnesia / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root/ big OK: 4911 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

pgsql_mnesia_26 / pgsql_mnesia / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root/ big OK: 4911 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

mssql_mnesia_26 / odbc_mssql_mnesia / a68288655c4c9ae2afb5524c71d1fde53d26b1fd Reports root/ big OK: 4908 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 97.95918% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.51%. Comparing base (0912480) to head (b768315).

Files	Patch %	Lines
src/instrument/mongoose_instrument.erl	95.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feature/instrument #4249 +/- ## ====================================================== + Coverage 84.23% 84.51% +0.27% ====================================================== Files 556 556 Lines 33660 33695 +35 ====================================================== + Hits 28354 28476 +122 + Misses 5306 5219 -87 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mongoose-im commented 1 month ago

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / fb717153818f6017442d27099fb7205e2af643f8 Reports root/ big OK: 435 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0

small_tests_25 / small_tests / fb717153818f6017442d27099fb7205e2af643f8 Reports root / small

small_tests_26 / small_tests / fb717153818f6017442d27099fb7205e2af643f8 Reports root / small

small_tests_26_arm64 / small_tests / fb717153818f6017442d27099fb7205e2af643f8 Reports root / small

ldap_mnesia_25 / ldap_mnesia / fb717153818f6017442d27099fb7205e2af643f8 Reports root/ big OK: 2275 / Failed: 0 / User-skipped: 895 / Auto-skipped: 0

ldap_mnesia_26 / ldap_mnesia / fb717153818f6017442d27099fb7205e2af643f8 Reports root/ big OK: 2275 / Failed: 0 / User-skipped: 895 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / fb717153818f6017442d27099fb7205e2af643f8 Reports root/ big OK: 4522 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

dynamic_domains_mysql_redis_26 / mysql_redis / fb717153818f6017442d27099fb7205e2af643f8 Reports root/ big OK: 4488 / Failed: 1 / User-skipped: 138 / Auto-skipped: 0

carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons

```erlang {error, {{badmatch, [{xmlel,<<"message">>, [{<<"from">>, <<"alice_dropped_client_doesnt_create_duplicate_carbons_586@domain.example.com">>}, {<<"to">>, <<"alice_dropped_client_doesnt_create_duplicate_carbons_586@domain.example.com/res2">>}, {<<"xmlns">>,<<"jabber:client">>}, {<<"type">>,<<"chat">>}], [{xmlel,<<"sent">>, [{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}], [{xmlel,<<"forwarded">>, [{<<"xmlns">>,<<"urn:xmpp:forward:0">>}], [{xmlel,<<"message">>, [{<<"from">>, <<"alice_dropped_client_doesnt_create_duplicate_carbons_586@domain.example.com/res1">>}, {<<"type">>,<<"chat">>}, {<<"to">>, <<"bob_dropped_client_doesnt_create_duplicate_carbons_586@domain.example.com/res1">>}, {<<"xmlns">>,<<"jabber:client">>}], [{xmlel,<<"body">>,[], [{xmlcdata, <<"And pious action">>}]}]}]}]}]}]}, [{carboncopy_SUITE, '-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4, [{file, "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"}, {line,189}]}, {escalus_story,story,4, [{file, "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"}, {line,72}]}, {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]}, {test_server,run_test_c... ``` [Report log](https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4249/213269/mysql_redis.26.1.2-amd64/big/ct_run.test%40301cf75dbfd1.2024-03-22_18.00.42/big_tests.tests.carboncopy_SUITE.logs/run.2024-03-22_18.01.31/carboncopy_suite.dropped_client_doesnt_create_duplicate_carbons.12804.html)

dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / fb717153818f6017442d27099fb7205e2af643f8 Reports root/ big OK: 4522 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

internal_mnesia_26 / internal_mnesia / fb717153818f6017442d27099fb7205e2af643f8 Reports root/ big OK: 2415 / Failed: 0 / User-skipped: 755 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / fb717153818f6017442d27099fb7205e2af643f8 Reports root/ big OK: 4911 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / fb717153818f6017442d27099fb7205e2af643f8 Reports root/ big OK: 4519 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0

pgsql_cets_26 / pgsql_cets / fb717153818f6017442d27099fb7205e2af643f8 Reports root/ big OK: 4439 / Failed: 0 / User-skipped: 174 / Auto-skipped: 0

mysql_redis_26 / mysql_redis / fb717153818f6017442d27099fb7205e2af643f8 Reports root/ big OK: 4890 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

pgsql_mnesia_26 / pgsql_mnesia / fb717153818f6017442d27099fb7205e2af643f8 Reports root/ big OK: 4911 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

mssql_mnesia_26 / odbc_mssql_mnesia / fb717153818f6017442d27099fb7205e2af643f8 Reports root/ big OK: 4908 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0

mongoose-im commented 1 month ago

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root/ big OK: 435 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0

small_tests_25 / small_tests / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root / small

small_tests_26 / small_tests / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root / small

small_tests_26_arm64 / small_tests / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root / small

ldap_mnesia_25 / ldap_mnesia / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root/ big OK: 2275 / Failed: 0 / User-skipped: 895 / Auto-skipped: 0

ldap_mnesia_26 / ldap_mnesia / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root/ big OK: 2275 / Failed: 0 / User-skipped: 895 / Auto-skipped: 0

dynamic_domains_mysql_redis_26 / mysql_redis / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root/ big OK: 4489 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root/ big OK: 4522 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

internal_mnesia_26 / internal_mnesia / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root/ big OK: 2415 / Failed: 0 / User-skipped: 755 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root/ big OK: 4911 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

pgsql_cets_26 / pgsql_cets / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root/ big OK: 4439 / Failed: 0 / User-skipped: 174 / Auto-skipped: 0

pgsql_mnesia_26 / pgsql_mnesia / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root/ big OK: 4911 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root/ big OK: 4519 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0

mysql_redis_26 / mysql_redis / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root/ big OK: 4890 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

mssql_mnesia_26 / odbc_mssql_mnesia / b768315ac80e3027ce7cc2e7dc1625840cd334fe Reports root/ big OK: 4908 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0

esl / MongooseIM

Instrument/metric improvements #4249

Codecov Report