search

esl / MongooseIM

MongooseIM is Erlang Solutions' robust, scalable and efficient XMPP server, aimed at large installations. Specifically designed for enterprise purposes, it is fault-tolerant and can utilise the resources of multiple clustered machines.
Other
1.64k stars 420 forks source link

Make commit hash in system status fail-safe #4262

Closed chrzaszcz closed 3 weeks ago

chrzaszcz commented 3 weeks ago

This hotfix is needed to make the build for the 6.2.1 release pass. The tests were failing only for GH tags, because the commit hash was not available.

For now - default to an empty string. We could make the field optional in the future to clean this up.

Big tests checked manually with and without the commit hash.

mongoose-im commented 3 weeks ago

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root/ big OK: 437 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0

small_tests_25 / small_tests / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root / small

small_tests_26 / small_tests / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root / small

small_tests_26_arm64 / small_tests / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root / small

ldap_mnesia_25 / ldap_mnesia / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0

dynamic_domains_mysql_redis_26 / mysql_redis / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root/ big OK: 4508 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root/ big OK: 4541 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

ldap_mnesia_26 / ldap_mnesia / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root/ big OK: 4541 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

internal_mnesia_26 / internal_mnesia / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root/ big OK: 2424 / Failed: 0 / User-skipped: 757 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root/ big OK: 4538 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root/ big OK: 4930 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0

pgsql_cets_26 / pgsql_cets / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root/ big OK: 4456 / Failed: 0 / User-skipped: 178 / Auto-skipped: 0

pgsql_mnesia_26 / pgsql_mnesia / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root/ big OK: 4930 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0

mysql_redis_26 / mysql_redis / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root/ big OK: 4909 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0

mssql_mnesia_26 / odbc_mssql_mnesia / 8796d69eac91d6c79ad8584c49c950125fbb34a3 Reports root/ big OK: 4927 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

mongoose-im commented 3 weeks ago

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 437 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0

small_tests_25 / small_tests / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root / small

small_tests_26 / small_tests / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root / small

small_tests_26_arm64 / small_tests / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root / small

ldap_mnesia_25 / ldap_mnesia / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 4541 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

dynamic_domains_mysql_redis_26 / mysql_redis / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 4508 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0

ldap_mnesia_26 / ldap_mnesia / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 4538 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

internal_mnesia_26 / internal_mnesia / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 2424 / Failed: 0 / User-skipped: 757 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 4541 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

pgsql_cets_26 / pgsql_cets / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 4455 / Failed: 1 / User-skipped: 178 / Auto-skipped: 0

graphql_SUITE:tls_enabled:tls_connect_admin_unknown_certificate ```erlang {error,{{assertMatch,[{module,graphql_SUITE}, {line,253}, {expression,"Result"}, {pattern,"{ error , { tls_alert , { unknown_ca , _ } } }"}, {value,{error,connection_closed}}]}, [{graphql_SUITE,tls_connect_admin_unknown_certificate,1, [{file,"/home/circleci/project/big_tests/tests/graphql_SUITE.erl"}, {line,253}]}, {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]}, {test_server,run_test_case_eval1,6, [{file,"test_server.erl"},{line,1302}]}, {test_server,run_test_case_eval,9, [{file,"test_server.erl"},{line,1234}]}]}} ``` [Report log](https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4262/215061/pgsql_cets.26.2.2-amd64/big/ct_run.test%409c820cb64a00.2024-04-11_12.56.02/big_tests.tests.graphql_SUITE.logs/run.2024-04-11_12.58.03/graphql_suite.tls_connect_admin_unknown_certificate.21508.html)

pgsql_mnesia_25 / pgsql_mnesia / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 4930 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0

mysql_redis_26 / mysql_redis / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 4909 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0

pgsql_mnesia_26 / pgsql_mnesia / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 4930 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0

mssql_mnesia_26 / odbc_mssql_mnesia / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 4927 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

pgsql_cets_26 / pgsql_cets / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 4455 / Failed: 1 / User-skipped: 178 / Auto-skipped: 0

graphql_roster_SUITE:user_roster:user_decline_subscription_ask ```erlang {error, {timeout_when_waiting_for_stanza, [{escalus_client,wait_for_stanza, [{client, <<"bob_user_decline_subscription_ask_1168@localhost/res1">>, escalus_tcp,<0.26408.0>, [{event_manager,<0.26406.0>}, {server,<<"localhost">>}, {username,<<"bOb_user_decline_subscription_ask_1168">>}, {resource,<<"res1">>}], [{event_client, [{event_manager,<0.26406.0>}, {server,<<"localhost">>}, {username, <<"bOb_user_decline_subscription_ask_1168">>}, {resource,<<"res1">>}]}, {resource,<<"res1">>}, {username,<<"bob_user_decline_subscription_ask_1168">>}, {server,<<"localhost">>}, {host,<<"localhost">>}, {port,5222}, {auth,{escalus_auth,auth_plain}}, {wspath,undefined}, {username,<<"bOb_user_decline_subscription_ask_1168">>}, {server,<<"localhost">>}, {password,<<"makrolika">>}, {stream_id,<<"74d0a9c3fb93771d">>}]}, 1], [{file, "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"}, {line,136}]}, {graphql_roster_SUITE,user_decline_subscription_ask_story,3, [{file, "/home/circleci/project/big_tests/tests/graphql_roster_SUITE.erl"}, {line,524}]}, {escalus_story,story,4, [{file, "/home/circleci/project/big_tests/_buil... ``` [Report log](https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4262/215107/pgsql_cets.26.2.2-amd64/big/ct_run.test%40812c17346e51.2024-04-11_13.19.27/big_tests.tests.graphql_roster_SUITE.logs/run.2024-04-11_13.24.38/graphql_roster_suite.user_decline_subscription_ask.html)

pgsql_cets_26 / pgsql_cets / 1978e2d1ca467a34dd10f0589aee987bab693a38 Reports root/ big OK: 4456 / Failed: 0 / User-skipped: 178 / Auto-skipped: 0

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.42%. Comparing base (5f2bc39) to head (1978e2d). Report is 2 commits behind head on master.

Files Patch % Lines
src/mongoose_server_api.erl 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4262 +/- ## ========================================== + Coverage 84.40% 84.42% +0.01% ========================================== Files 552 552 Lines 33551 33554 +3 ========================================== + Hits 28319 28327 +8 + Misses 5232 5227 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.