Closed chrzaszcz closed 1 week ago
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root/ big OK: 447 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
small_tests_25 / small_tests / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root / small
small_tests_26 / small_tests / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root / small
small_tests_26_arm64 / small_tests / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root / small
ldap_mnesia_25 / ldap_mnesia / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0
ldap_mnesia_26 / ldap_mnesia / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root/ big OK: 4575 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
dynamic_domains_mysql_redis_26 / mysql_redis / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root/ big OK: 4542 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root/ big OK: 4575 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
internal_mnesia_26 / internal_mnesia / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root/ big OK: 2423 / Failed: 1 / User-skipped: 757 / Auto-skipped: 0
dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root/ big OK: 4572 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0
pgsql_cets_26 / pgsql_cets / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root/ big OK: 4480 / Failed: 0 / User-skipped: 174 / Auto-skipped: 0
mysql_redis_26 / mysql_redis / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root/ big OK: 4943 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0
pgsql_mnesia_25 / pgsql_mnesia / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root/ big OK: 4964 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0
mssql_mnesia_26 / odbc_mssql_mnesia / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root/ big OK: 4977 / Failed: 3 / User-skipped: 115 / Auto-skipped: 0
pgsql_mnesia_26 / pgsql_mnesia / 2196bd5375576b257c8630a4bebe66729a41ac7c Reports root/ big OK: 4964 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0
Attention: Patch coverage is 98.33333%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 84.32%. Comparing base (
a8a8464
) to head (a1c639f
).
Files | Patch % | Lines |
---|---|---|
src/instrument/mongoose_instrument_probe.erl | 87.50% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root/ big OK: 447 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
small_tests_25 / small_tests / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root / small
small_tests_26 / small_tests / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root / small
small_tests_26_arm64 / small_tests / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root / small
ldap_mnesia_25 / ldap_mnesia / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0
ldap_mnesia_26 / ldap_mnesia / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root/ big OK: 2283 / Failed: 1 / User-skipped: 897 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root/ big OK: 4575 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
dynamic_domains_mysql_redis_26 / mysql_redis / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root/ big OK: 4542 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0
dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root/ big OK: 4572 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0
internal_mnesia_26 / internal_mnesia / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root/ big OK: 2415 / Failed: 2 / User-skipped: 632 / Auto-skipped: 132
pgsql_cets_26 / pgsql_cets / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root/ big OK: 4480 / Failed: 0 / User-skipped: 174 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root/ big OK: 4575 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
pgsql_mnesia_25 / pgsql_mnesia / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root/ big OK: 4982 / Failed: 1 / User-skipped: 112 / Auto-skipped: 0
mysql_redis_26 / mysql_redis / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root/ big OK: 4943 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0
pgsql_mnesia_26 / pgsql_mnesia / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root/ big OK: 4964 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0
mssql_mnesia_26 / odbc_mssql_mnesia / e0c0d6918bdebd95e017be5f4612a15b87445d8e Reports root/ big OK: 4961 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 447 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
small_tests_25 / small_tests / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root / small
small_tests_26 / small_tests / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root / small
small_tests_26_arm64 / small_tests / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root / small
ldap_mnesia_25 / ldap_mnesia / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0
dynamic_domains_mysql_redis_26 / mysql_redis / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 4542 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 4575 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
ldap_mnesia_26 / ldap_mnesia / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 4575 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
internal_mnesia_26 / internal_mnesia / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 2423 / Failed: 1 / User-skipped: 757 / Auto-skipped: 0
dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 4572 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0
pgsql_cets_26 / pgsql_cets / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 4480 / Failed: 0 / User-skipped: 174 / Auto-skipped: 0
mysql_redis_26 / mysql_redis / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 4943 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0
pgsql_mnesia_26 / pgsql_mnesia / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 4964 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0
mssql_mnesia_26 / odbc_mssql_mnesia / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 4961 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0
pgsql_mnesia_25 / pgsql_mnesia / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 4980 / Failed: 3 / User-skipped: 112 / Auto-skipped: 0
internal_mnesia_26 / internal_mnesia / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 2424 / Failed: 0 / User-skipped: 757 / Auto-skipped: 0
pgsql_mnesia_25 / pgsql_mnesia / a4ce3843af591011d4091d47c7c6e3011a17f441 Reports root/ big OK: 4964 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 447 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
small_tests_25 / small_tests / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root / small
small_tests_26 / small_tests / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root / small
small_tests_26_arm64 / small_tests / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root / small
ldap_mnesia_25 / ldap_mnesia / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0
ldap_mnesia_26 / ldap_mnesia / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0
dynamic_domains_mysql_redis_26 / mysql_redis / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 4542 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 4575 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 4575 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 4571 / Failed: 1 / User-skipped: 108 / Auto-skipped: 0
pgsql_cets_26 / pgsql_cets / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 4480 / Failed: 0 / User-skipped: 174 / Auto-skipped: 0
pgsql_mnesia_25 / pgsql_mnesia / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 4964 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0
internal_mnesia_26 / internal_mnesia / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 2424 / Failed: 0 / User-skipped: 757 / Auto-skipped: 0
mysql_redis_26 / mysql_redis / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 4943 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0
pgsql_mnesia_26 / pgsql_mnesia / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 4964 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0
mssql_mnesia_26 / odbc_mssql_mnesia / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 4960 / Failed: 1 / User-skipped: 115 / Auto-skipped: 0
dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 4572 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0
mssql_mnesia_26 / odbc_mssql_mnesia / b11af7b7a8881245718dafd5e98ef7f8ad702d68 Reports root/ big OK: 4957 / Failed: 4 / User-skipped: 115 / Auto-skipped: 0
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root/ big OK: 447 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
small_tests_25 / small_tests / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root / small
small_tests_26 / small_tests / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root / small
small_tests_26_arm64 / small_tests / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root / small
ldap_mnesia_25 / ldap_mnesia / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root/ big OK: 4575 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
ldap_mnesia_26 / ldap_mnesia / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root/ big OK: 4575 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
dynamic_domains_mysql_redis_26 / mysql_redis / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root/ big OK: 4542 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0
internal_mnesia_26 / internal_mnesia / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root/ big OK: 2424 / Failed: 0 / User-skipped: 757 / Auto-skipped: 0
dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root/ big OK: 4572 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0
pgsql_cets_26 / pgsql_cets / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root/ big OK: 4480 / Failed: 0 / User-skipped: 174 / Auto-skipped: 0
pgsql_mnesia_25 / pgsql_mnesia / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root/ big OK: 4964 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0
pgsql_mnesia_26 / pgsql_mnesia / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root/ big OK: 4964 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0
mysql_redis_26 / mysql_redis / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root/ big OK: 4943 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0
mssql_mnesia_26 / odbc_mssql_mnesia / 7b817ff82a96414764bc811de818eba3b975cf27 Reports root/ big OK: 4961 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 447 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
small_tests_25 / small_tests / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root / small
small_tests_26 / small_tests / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root / small
small_tests_26_arm64 / small_tests / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root / small
ldap_mnesia_25 / ldap_mnesia / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 4575 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
ldap_mnesia_26 / ldap_mnesia / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0
dynamic_domains_mysql_redis_26 / mysql_redis / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 4541 / Failed: 1 / User-skipped: 138 / Auto-skipped: 0
dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 4575 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0
internal_mnesia_26 / internal_mnesia / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 2423 / Failed: 1 / User-skipped: 757 / Auto-skipped: 0
dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 4576 / Failed: 14 / User-skipped: 108 / Auto-skipped: 0
pgsql_cets_26 / pgsql_cets / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 4480 / Failed: 0 / User-skipped: 174 / Auto-skipped: 0
pgsql_mnesia_25 / pgsql_mnesia / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 4964 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0
pgsql_mnesia_26 / pgsql_mnesia / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 4964 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0
mysql_redis_26 / mysql_redis / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 4943 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0
mssql_mnesia_26 / odbc_mssql_mnesia / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 4961 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0
dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 4572 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0
internal_mnesia_26 / internal_mnesia / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 2424 / Failed: 0 / User-skipped: 757 / Auto-skipped: 0
dynamic_domains_mysql_redis_26 / mysql_redis / a1c639fa21dff5f04e3f7fd246b6b73c63676a9b Reports root/ big OK: 4542 / Failed: 0 / User-skipped: 138 / Auto-skipped: 0
The main goal is to support probes in
mongoose_instrument
.A probe is a metric (typically a gauge - simple numerical value), that is updated with a callback function.
The probe is executed at a configurable rate. By default the interval is 15 seconds, and it can be modified:
instrumentation.probe_interval
option in TOML,probe => #{interval => ...}}
option.Previously the interval was the same as the
exometer
report interval, but the new design separates instrumentation from data collection, so we don't want to have such dependencies. Furthermore, for Prometheus we don't know the scrape interval.Other changes:
loglevel
to theconfig()
type.Notes: both Exometer and Prometheus have behaviours for callback modules, that can provide metrics directly. This way there would be no interval, and each reporting/scraping event would cause direct calls to calculate the metrics. I implemented and benchmarked that solution, and for
mod_muc
(with 10k rooms) it would cause noticeable delays in the Prometheus Cowboy endpoint, so I didn't include the solution in this PR. I could make a separate PR for it though.Additionally, I think that if the calculation is periodic, there is no benefit in using the Prometheus/Exometer-specific callback modules, so I chose to use the periodic events instead. This way it is also possible to log the events for debugging.
Regarding coverage: the only uncovered line is tested in the upcoming MUC PR.