This awaited PR addresses the story of making it possible to perform a proper (in terms of already developed APIs) push notification send request to phoenix backend HTTP endpoint (APIv1/APIv2/APIv3). Successful requests are replied with 200 status, while improper ones with 422, including the brief description of what is not valid within the request.
In the home stretch I took the opportunity to remove unused code introduced in one of the former PRs, as well as did some minor alignments to already existing schemas definitions.
Known shortcomings of this PR:
for APIv2/3 scenarios OpenApiSpex schemas validator does not return meaningful errors where expected - root cause has already been identified, workaround will follow soon;
unit tests should be done in property-based testing manner - to be implemented in the upcoming sprint.
This awaited PR addresses the story of making it possible to perform a proper (in terms of already developed APIs) push notification send request to phoenix backend HTTP endpoint (APIv1/APIv2/APIv3). Successful requests are replied with
200status, while improper ones with422, including the brief description of what is not valid within the request.In the home stretch I took the opportunity to remove unused code introduced in one of the former PRs, as well as did some minor alignments to already existing schemas definitions.
Known shortcomings of this PR:
OpenApiSpexschemas validator does not return meaningful errors where expected - root cause has already been identified, workaround will follow soon;