search

esl / MongoosePush

MongoosePush is a simple Elixir RESTful service allowing to send push notification via FCM and/or APNS.
Apache License 2.0
108 stars 24 forks source link

Remove obsolete :mock and :meck dependencies #181

Closed kmakiela closed 4 years ago

kmakiela commented 4 years ago

This PR removes :meck and :mock from the dependency list. Both :meck and :mock are not needed anymore. All the tests that used these libraries were already rewritten (most of them use :mox now).

NelsonVides commented 4 years ago

So cool it would be so simple to get rid of Mock 😄 But what about the mix.lock file, doesn't that one need to be cleaned out as well?

michalwski commented 4 years ago

@kmakiela I second @NelsonVides questions. Looks like mix.lock needs an update.

kmakiela commented 4 years ago

Further investigation shows that :meck is still loaded as a Sparrow dependency (and Sparrow only) so this PR is temporarily blocked by: https://github.com/esl/sparrow/pull/47

NelsonVides commented 4 years ago

@kmakiela https://github.com/esl/sparrow/pull/47 was merged, we can move forward with this one 🙂