search

esl / MongoosePush

MongoosePush is a simple Elixir RESTful service allowing to send push notification via FCM and/or APNS.
Apache License 2.0
108 stars 24 forks source link

Add migration instructions for configuration files #189

Closed kmakiela closed 4 years ago

kmakiela commented 4 years ago

This PR introduces a first version of the migration guide. For now it includes changes in the configuration files only. Additionally, there are changes to the relative links to the other parts of the documentation as they were not working properly

michalwski commented 4 years ago

@janciesla8818 thanks for applying my suggestions. I think we still have one thing left to be sorted out:

Also, I'm wondering in what case a MongoosePush user needs to change the elixir config files when switching to version 2.1.0. In the most common case when MongoosePush is deployed from a docker image and configured with only env variables, there is no need to modify any of the config/*.exs files. Am I missing something?

While it's good to have all the changes visible in the migration guide, I don't want to confuse people and rush them to change anything if it's not required.

janciesla8818 commented 4 years ago

@michalwski, thanks for the review comments. The first section of the document was updated to address this remark.

Also, I'm wondering in what case a MongoosePush user needs to change the elixir config files when switching to version 2.1.0. In the most common case when MongoosePush is deployed from a docker image and configured with only env variables, there is no need to modify any of the config/*.exs files. Am I missing something?