Fix preferences window not showing up.

esl / erlang-osx-installer

Erlang Installer & Auto-Updater for macOS

https://www.erlang-solutions.com/resources/download.html

Apache License 2.0

5 stars 5 forks source link

Fix preferences window not showing up. #102

Closed volbap closed 7 years ago

volbap commented 7 years ago

The window instance needs to be kept in the class scope, otherwise it gets released when going out of the function scope, because of ARC. Once again, thanks stack overflow, hehe.
⛔️ @sebacancinos check out that currently, the app is crashing (EXC_BAD_ACCESS) when you close the preferences pane. I bet you will manage to fix that in your branch.

volbap commented 7 years ago

Also, I've added a commit that removes the singleton instance and fixes the crash with the X button.

What's left is to make the window always visible, so that it doesn't get lost when it loses focus. Have in mind that this window does not appear in Mission Control, which is normal behavior for this kind of windows. Take the Freckle App settings pane as an example.

sebacancinos commented 7 years ago

There is a newer PR that incorporates this changes and is already merged into master.