search

esl / erlang_ale

Erlang Actor Library for Embedded -- An embedded framework from Erlang Solutions
Apache License 2.0
207 stars 65 forks source link

too much loggin in c_src #11

Closed stuart-thackray closed 9 years ago

stuart-thackray commented 10 years ago

Hi,

there is too much logging in the c_src, for example in gpio src for time sensitive applications, which use up too much of CPU or IO.

For example I transformed this python code (http://learn.adafruit.com/adafruits-raspberry-pi-lesson-10-stepper-motors/software) into http://www.pasteall.org/50299

I was struggling to figure out what might be the problem, I removed the erlang logging which made no difference, I also checked top then found the problem. Knew it wasn't erlang, was getting worried/nervious.

I am no C expert but will try and remove unneeded logging in my opion.

stuart-thackray commented 10 years ago

Hi Thanks again for great library,

Please can we remove successful logging as per my pull request or can you do it via ifdef compiles for c please. https://github.com/esl/erlang_ale/pull/12

I have leds attacked to my motor, but internet not fast enough to show removing of logging has for the speed of the library.

lehoff commented 10 years ago

Agreed - no need for the logging now that the software is more stable.

notifications@github.com writes:

Hi,

there is too much logging in the c_src, for example in gpio src for time sensitive applications, which use up too much of CPU or IO.

For example I transformed this python code (http://learn.adafruit.com/adafruits-raspberry-pi-lesson-10-stepper-motors/software) into http://www.pasteall.org/50299

I was struggling to figure out what might be the problem, I removed the erlang logging which made no difference, I also checked top then found the problem. Knew it wasn't erlang, was getting worried/nervious.

I am no C expert but will try and remove unneeded logging in my opion.

Reply to this email directly or view it on GitHub: https://github.com/esl/erlang_ale/issues/11

Torben Hoffmann CTO Erlang Solutions Ltd. Tel: +45 25 14 05 38 http://www.erlang-solutions.com

knewter commented 9 years ago

This should be closed now that I've merged #12