search

esl / escalus

An XMPP client library in Erlang for conveniently testing XMPP servers
Apache License 2.0
130 stars 76 forks source link

Channel binding flag depending on ssl driver #229

Closed NelsonVides closed 4 years ago

NelsonVides commented 4 years ago

If we're using a regular OTP's SSL driver, default to simply n as a flag; if fast_tls, then as required in the RFC, always notify client's support with either y or p. Also update fast_tls to master.

Quick and I believe nice fix to today's discussion 🙂

NelsonVides commented 4 years ago

Thanks for the change! Could you quickly change the fast_tls dependency specification to use hex.pm package. Version 1.1.5 includes what we need.

I'm not sure, version 1.1.5 seems to have had some issue that P1 fixed in a couple of subsequent commits, here I'm upgrading to these. I think we can have a future PR when there's a new hex package for the committed changes 🤔

michalwski commented 4 years ago

I'm not sure, version 1.1.5 seems to have had some issue that P1 fixed in a couple of subsequent commits, here I'm upgrading to these. I think we can have a future PR when there's a new hex package for the committed changes

Right, I noticed that after making the comment.

janciesla8818 commented 4 years ago

Really quick and nice fix to today's discussion :D

Thanks @NelsonVides !