search

esl / gradient

Gradient is a static typechecker for Elixir
Apache License 2.0
437 stars 13 forks source link

Check apps in an umbrella project #138

Closed luk-pau-es closed 1 year ago

luk-pau-es commented 2 years ago

This branch is based on: #124 What was done:

Issue of the bug: On file lib/gradient.ex we call function maybe_specify_forms/2 on line 46. Before that (line: 45) there is call to function put_source_path/2. Bug cause was that maybe_specify_forms/2 also called this put_source_path/2 which effectively aded source paths 2 times. I have verified that maybe_specify_forms/2 is called only from that one specific location and removed redundant call to put_source_path/2 from inside it.

IMPORTANT Right now the pipeline is all green but I need to investigate more about it as this is effect of re running failed jobs multiple times.

japhib commented 1 year ago

Hi @luk-pau-es, I've looked through this branch and it looks good to me for the most part -- I added some more changes on top of #124 since you branched off that MR, which I would like to be added here as well. I added all those changes in one commit on top of your branch, here: https://github.com/japhib/gradient/commit/406c7f642ec3bb7684646075e2622a8f176ef41a

Mind cherry-picking it?

japhib commented 1 year ago

Thanks for all your help @luk-pau-es @erszcz !