search

esl / ice

Apache License 2.0
2 stars 4 forks source link

Fixing assumptions in visitor #18

Closed fenollp closed 11 years ago

fenollp commented 11 years ago

So that is the end of "Is that a dimension or a variable?" talk we had this morning. TransLucid's documentation is clear on the point (expressed in two places here) I had doubts about: lhs of tuples and argument of context-query is a dimension.

Note: I removed completely one unit test (test/tea_tests:tuple2_test_/0) because of the unclear nature of its asserted outcome. (Should the outcome really be just a list of dimensions? Not something more complex?)

lucafavatella commented 11 years ago

The expression is: [#.t <- 0, #.s <- 1]

My understanding is that this expressions is evaluating #.t (that requires t to be a known dimension) and assigning 0 to the dimension identifier returned by #.t. And doing the analogous for s.

My understanding is that the return value is correctly a list of dimensions, as the context queries (#.) require dimensions to be known, therefore the evaluation returns the missing dimensions.

The only "problem" that I see here is that I am not yet sure if the value of a dimension can be a dimension itself (equivalent to saying that dimensions can be any ground value?).

Ed?

et4te commented 11 years ago

I am confused by your comment.

fenollp commented 11 years ago

Luca is talking about the test I remove in this PR.