search

esl / ice

Apache License 2.0
2 stars 4 forks source link

Add tests for cache #44

Closed lucafavatella closed 10 years ago

lucafavatella commented 10 years ago

This pull request probably requires to be reconsidered after recent work by Ed on the cache.

lucafavatella commented 10 years ago

Branch tested also with ets_cache branch by Ed https://github.com/esl/tea/tree/ets_cache 9a92f4ba1f5a44893b5b9afc6a79ba3dcfe34164 (1 month ago). The test try_to_find_wo_knowing_enough_needed_dims fails with error error_calc , so the ets cache gives no improvement re this test.

lucafavatella commented 10 years ago

Ed,

I created branch superfluous-calc-by-cache-w-ets_cache that merges the ets_cache branch into this branch. https://github.com/lucafavatella/tea/commits/superfluous-calc-by-cache-w-ets_cache

In particular, I added a commit that I think shows the crux of all this, can you have a look at it? https://github.com/lucafavatella/tea/commit/0ce079ffd0df1af8e8b81080875e19561257ddb1 That commit basically shows that someone (either the tcache module or the data structure module) needs to take care of the case of internal node with multiple missing dimensions.

Let me know if you prefer me to propose a fix (I would need to put it either in tcache or tdtree_ets).