ICE shell - Githubissues

esl / ice

Apache License 2.0

2 stars 4 forks source link

Closed horvand closed 8 years ago

horvand commented 9 years ago

var|dim|fun definitions are appended to an implicit WHERE-clause
re-defining an identifier replaces the old definition
expressions evaluated using the global WHERE-clause
commands:
- :q Quit
- :d Delete all definitions
- :p Print definitions
- :l FILE load definitions from FILE (has to contain defs)

Close #70

et4te commented 9 years ago

Is there any reason that the function ice:f/1 is not used here to load a file?

horvand commented 9 years ago

What's missing:

[X] proper file-loading
[X] recognising line continuation on stdin
[x] terminal-type check in the sh scriptlet (don't want rlwrap to interfere with Emacs or Acme :) )
[x] some command to measure time (:t',:t `)
[x] command line args
[x] cleanup, formatting
[ ] doc

horvand commented 9 years ago

@et4te This PR is in pretty good shape now, we might consider merging it to master.

horvand commented 9 years ago

@lucafavatella Please consider merging this PR, I think an interactive shell is a very useful functionality.

lucafavatella commented 8 years ago

It looks good to me. Comments:

I did not attempt to find a failing test case, but I am convinced that a fresh cache shall be used at every evaluation because variables could be defined (potentially even re-defined as validation on variables in not complete) in the expression entered (then wrapped in the top-level where);
A :help or similar command would be nice to have, but the code is clean enough;
Issues with Unicode characters (useful for e.g. intensions) - I will propose separate PR for this.

BTW codebase in master does not pass tests but it is not an issue if this PR.