search

esl / jerboa

STUN/TURN encoder, decoder and client library in Elixir
https://www.erlang-solutions.com/products/mongooseim.html
Other
14 stars 6 forks source link

Just some typos to fix #118

Closed ACollectionOfAtoms closed 4 years ago

ACollectionOfAtoms commented 4 years ago

CI failing for typo fix? :sadcat:

gustawlippa commented 4 years ago

Hi! Thank you for your contribution! Not only a good typo catch but it exposed problems on the CI, so twice the profit. For now I've pushed a quick fix in #119 but we'll keep a closer eye for OTP versions in the future. That PR is already merged, so if you rebase onto master, all should be green and I will be able to merge your fix.

jerboabot commented 4 years ago

Hello, @ACollectionOfAtoms! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

ACollectionOfAtoms commented 4 years ago

@gustawlippa should be good 2 go!

gustawlippa commented 4 years ago

Thanks! 👍