jerboabot
commented
7 years ago Ebert has finished reviewing this Pull Request and has found:
- 2 possible new issues (including those that may have been commented here).
But beware that this branch is 14 commits behind the esl:master branch, and a review of an up to date branch would produce more accurate results.
You can see more details about this review at https://ebertapp.io/github/esl/jerboa/pulls/99.
erszcz
The token size is strictly defined, but it's not exported from the module for outside use. Moreover, passing a value of a wrong size will not error on creation, but on encoding, which is quite late. Having a constructor can solve both of these and make external usage more convenient.