Closed arkgil closed 5 years ago
I've just recalled #4 PR where we had the idea to add CLUSTER_WITH
var. I imagine this could work like this:
CLUSTER_WITH
is not set, the current behaviour happensCLUSTER_WITH
is set to false
, there is no clustering at allCLUSTER_WITH
is set to anything else, the script tries to cluster with then node passed in the var.What do you think @arkgil? Does it make sense? Would you find some time to implement this (if it makes sens).
@michalwski thanks for the review :) Yes, it does make sense. I'm all for making the clustering behaviour more controllable.
@michalwski I think that we need additional portion of explicitness, i.e. CLUSTER_WITH
will point at node with whom the starting node will try to clusterize (we'll keep the default the same as current CLUSTER_NODE
), but I'd also add JOIN_CLUSTER
variable (true
by default) which will determine if clustering will be attempted at all.
@arkgil yes, that'd be simpler and clearer. Good idea.
@michalwski done 🙂
@michalwski yes I have and it's working as expected. I've also removed --add-host
solution and instead used a dedicated Docker network + container names.
Thanks for the PR @arkgil, this make sense. Could you add a short description of this option to the
README.md
file?