search

esla-ahme / JS-Calculator-

Primitive operation calculator using js
GNU General Public License v3.0
0 stars 2 forks source link

Add new operations #1

Open esla-ahme opened 4 years ago

esla-ahme commented 4 years ago

Support power, square root, undo and redo buttons

Kardelio commented 4 years ago

Id be really interested in taking a look at this if you wouldn't mind? Im currently learning about CSS grid and well this calculator is an awesome example of it? Is that ok if I pick this up? (I cant promise ill be super quick)...

If so did you have any rough design idea in mind? For example where should these extra buttons sit on this calculator? BTW awesome job on this so far its really clean and nicely coded!

Kardelio commented 4 years ago

Also regarding the "don't use any frameworks or external libraries", would Math fall into that category? The MDN docs (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math) refer to it as "a built-in object that has properties and methods for mathematical constants and functions."

So in my mind Math would be OK to use?

esla-ahme commented 4 years ago

Go for it. No it's ok to use Math, I meant things like jquery

Kardelio commented 4 years ago

Awesome! Ill get on it TY!

Kardelio commented 4 years ago

PR here: #2 @esla-ahme (noted this in the PR) but I have addressed just the power of and sqrt button for now as I think the redo and undo functionality would be good as another tkt/issue? what do you think is that ok?