eslavich / jirahub-sandbox

0 stars 0 forks source link

NIRSpec: calwebb_spec2 crashes with IFU data due to keyword issues #26

Open eslavichjgbot opened 4 years ago

eslavichjgbot commented 4 years ago

Issue JP-505 was created on JIRA by Maria Pena-Guerrero:

During the testing of the cube_build step in calwebb_spec2, the pipeline crashes due to an improper keyword INTARGET value. We changed the value to the boolean True, rather than the 'T' string,  and got the a very similar crashing output message.  We used simulated IFU data in PRISM mode.

Crassing message shows as follows:

2019-01-17 00:13:50,462 - stpipe.Spec2Pipeline.cube_build - INFO - Time to find Cube Flux= 0.0.s

2019-01-17 00:13:50,569 - stpipe.Spec2Pipeline.cube_build - WARNING - /Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/datamodels/validate.py:35: ValidationWarning: While validating <IFUCubeModel(941, 48, 46) from ditherunity_CLEAR_PRISM_M1_m1_noiseless_NRS1_modified_updatedHDR_cal.fits> the following error occurred:

'T' is not of type 'boolean'

 

Failed validating 'type' in schema['properties']['meta']['properties']['visit']['properties']['internal_target']:

    OrderedDict([('title', 'At least one exposure in visit is internal'),

                 ('type', 'boolean'),

                 ('fits_keyword', 'INTARGET'),

                 ('blend_table', True)])

 

On instance['meta']['visit']['internal_target']:

    'T'

  warnings.warn(errmsg, ValidationWarning)

 

2019-01-17 00:13:50,651 - stpipe.Spec2Pipeline.cube_build - INFO - Update S_REGION to POLYGON ICRS 156.177053996 -45.687668830 156.177053996 -45.686363274 156.178843368 -45.686363274 156.178843368 -45.687668830

2019-01-17 00:13:50,663 - stpipe.Spec2Pipeline.cube_build - INFO - Step cube_build done

Traceback (most recent call last):

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/pipeline/calwebb_spec2.py", line 91, in process

    asn.filename

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/pipeline/calwebb_spec2.py", line 293, in process_exposure_product

    self.save_model(result_extra[0], 's3d')

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/stpipe/step.py", line 786, in save_model

    **components

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/datamodels/model_base.py", line 504, in save

    self.to_fits(output_path, *args, **kwargs)

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/datamodels/model_base.py", line 589, in to_fits

    extensions=self._extensions) as ff:

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/datamodels/fits_support.py", line 386, in to_fits

    _save_from_schema(hdulist, tree, schema)

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/datamodels/fits_support.py", line 340, in _save_from_schema

    validator.validate(tree, _schema=schema)

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jsonschema/validators.py", line 130, in validate

    raise error

jsonschema.exceptions.ValidationError: 'T' is not of type 'boolean'

 

Failed validating 'type' in schema['properties']['meta']['properties']['visit']['properties']['internal_target']:

    OrderedDict([('title', 'At least one exposure in visit is internal'),

                 ('type', 'boolean'),

                 ('fits_keyword', 'INTARGET'),

                 ('blend_table', True)])

 

On instance['meta']['visit']['internal_target']:

    'T'


ERROR RUNNING STEP 'Spec2Pipeline':

    One or more products failed to process. Failing calibration.

Traceback (most recent call last):

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/stpipe/cmdline.py", line 297, in step_from_cmdline

    step.run(*positional)

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/stpipe/step.py", line 400, in run

    step_result = self.process(*args)

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/pipeline/calwebb_spec2.py", line 107, in process

    'One or more products failed to process. Failing calibration.'

RuntimeError: One or more products failed to process. Failing calibration.

 


Traceback (most recent call last):

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/EGG-INFO/scripts/strun", line 26, in

    step = Step.from_cmdline(sys.argv[1:])

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/stpipe/step.py", line 162, in from_cmdline

    return cmdline.step_from_cmdline(args)

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/stpipe/cmdline.py", line 297, in step_from_cmdline

    step.run(*positional)

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/stpipe/step.py", line 400, in run

    step_result = self.process(*args)

  File "/Users/sargent/anaconda/envs/jwst72/lib/python3.6/site-packages/jwst-0.12.2-py3.6-macosx-10.7-x86_64.egg/jwst/pipeline/calwebb_spec2.py", line 107, in process

    'One or more products failed to process. Failing calibration.'

RuntimeError: One or more products failed to process. Failing calibration.

eslavichjgbot commented 4 years ago

Comment by Beth Sargent on JIRA:

Phil, I changed the keywords INTARGET, TARGOOPP, ZEROFRAM, and DATAPROB from strings to Booleans, and now calwebb_spec2.cfg no longer crashes in the cube_build step.  Thank you!

eslavichjgbot commented 4 years ago

Comment by Beth Sargent on JIRA:

I should also note that the companion issue, JP-506 (the same NIRSpec IFU simulation data crashing in the msa_flagging step), has been resolved as well (in that case, by adding border columns/rows to increase data array size from 2040x2040 to 2048x2048).

eslavich commented 4 years ago

This is a comment going the other direction