search

eslavnov / pylips

Control Philips TVs (2015+) and Ambilight (+ Hue) through their reverse-engineered API (+ MQTT support!)
MIT License
342 stars 60 forks source link

Add supported TV models to the README #33

Closed lucasvdh closed 5 years ago

lucasvdh commented 5 years ago

Philips has provided the exact models which support the Jointspace protocol. Adding this to the README would seem useful to me.

eslavnov commented 5 years ago

Hey Lucas,

Thank you for the PR!

I've given it a lot of thought and I am afraid I'll have to decline this one. The reason is that there are different versions of the Joint Space API, which use different protocols and endpoints. While I am confident that the tool/documented endpoints work fine for modern TVs, I can not say the same about the older TVs with previous versions of Joint Space API. Given the fact that I don't own an older TV to properly test and document all the differences, I think adding the older models to the list of supported TVs might be misleading and lead to a lot of frustration from the owners of such TVs when the endpoints do not work as advertised.

I really appreciate all your input to this project, but I'll have to refuse this one. Sorry!

lucasvdh commented 5 years ago

Sure, no problem :man_shrugging: