`no-unused-disable` doesn't work with flat config

eslint-community / eslint-plugin-eslint-comments

Additional ESLint rules for directive comments of ESLint.

https://eslint-community.github.io/eslint-plugin-eslint-comments

MIT License

44 stars 6 forks source link

`no-unused-disable` doesn't work with flat config #133

Closed teppeis closed 4 months ago

teppeis commented 8 months ago

This rule is implemented by patching Linter, which seems to be causing this problem with new flat config.

The flat config allows reportUnusedDisableDirectives to be included in shareable config. The new RFC will also allow for more configuration flexibility (in ESLint v9 ?).

https://github.com/eslint/rfcs/pull/100

So it would be good to make this rule deprecated in the future.

original: https://github.com/mysticatea/eslint-plugin-eslint-comments/issues/79

ota-meshi commented 8 months ago

Thank you for posting the issue. As you say, I think no-unused-disable should be deprecated. I also think no-unused-enable can also be deprecated since the following PR was merged: https://github.com/eslint/eslint/pull/17611

teppeis commented 6 months ago

reportUnusedDisableDirectives:error released in v8.56.0 🚀

github-actions[bot] commented 4 months ago

This issue has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from issues that aren't actionable. Please reach out if you have more information for us! 🙂