search

eslint-community / eslint-plugin-eslint-comments

Additional ESLint rules for directive comments of ESLint.
https://eslint-community.github.io/eslint-plugin-eslint-comments
MIT License
51 stars 7 forks source link

Support `eslint-plugin-vue`'s disable comments #136

Closed FloEdelmann closed 8 months ago

FloEdelmann commented 11 months ago

In Vue Single File Components (*.vue files), "HTML comments" can be used to disable ESLint rules: https://eslint.vuejs.org/rules/comment-directive.html

<template>
  <!-- eslint-disable-next-line vue/max-attributes-per-line -->
  <div a="1" b="2" c="3" d="4" />
</template>

Unfortunately, those comments are not detected by eslint-plugin-eslint-comments.

github-actions[bot] commented 8 months ago

This issue has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from issues that aren't actionable. Please reach out if you have more information for us! 🙂

GrantGryczan commented 8 months ago

Hey? I still care about this.

FloEdelmann commented 8 months ago

I also would have expected a warning (in form of a comment, as a label does not trigger a notification) before this issue is automatically closed. @ota-meshi or @MichaelDeBoey, can you please reopen this issue?
(And feel free to hide these comments as off-topic.)

FloEdelmann commented 5 months ago

@MichaelDeBoey could you please reopen this issue and hide these comments as off-topic? The feature request is still valid.

GrantGryczan commented 5 months ago

I guess you could just recreate the issue?

FloEdelmann commented 5 months ago

Yep, did that now, see #212.