search

eslint-community / eslint-plugin-eslint-comments

Additional ESLint rules for directive comments of ESLint.
https://eslint-community.github.io/eslint-plugin-eslint-comments
MIT License
44 stars 6 forks source link

bot marks issues as stale without notifying the author beforehand #164

Closed DetachHead closed 4 months ago

DetachHead commented 6 months ago

i don't like stale bots as they often close issues that are still valid just because they haven't been commented on in a few weeks. but if you feel it's necessary to have one, i think it should first comment informing the author that the issue will be closed when it's first marked as stale. otherwise, there's no way for the author to know that the bot is waiting for a reply:

image

(from https://github.com/eslint-community/eslint-plugin-eslint-comments/issues/130#issuecomment-1865419778)

this would make it consistent with how stale bots work in other repos

GrantGryczan commented 5 months ago

Agreed, and I think #136 should be reopened as it's still an issue and I still care about it (despite that I'm not the one who reported it). Might want to take a look at the other closed issues too.

FloEdelmann commented 5 months ago

For quick reference: Here are all issues that were closed as stale: https://github.com/eslint-community/eslint-plugin-eslint-comments/issues?q=is%3Aissue+sort%3Aupdated-desc+is%3Aclosed+label%3AStale

Samuel-Therrien-Beslogic commented 4 months ago

Please re-open https://github.com/eslint-community/eslint-plugin-eslint-comments/issues/162#issuecomment-1963096815 and https://github.com/eslint-community/eslint-plugin-eslint-comments/issues/161#issuecomment-1963020327 I was never even notified of the stale tag and 1 week is way too short.

GrantGryczan commented 4 months ago

What about the issues that were closed as stale? May they be reopened please?