search

eslint-community / eslint-plugin-eslint-comments

Additional ESLint rules for directive comments of ESLint.
https://eslint-community.github.io/eslint-plugin-eslint-comments
MIT License
44 stars 6 forks source link

v4.0.0 dropped ESLint v8 support #89

Closed aarongoldenthal closed 11 months ago

aarongoldenthal commented 11 months ago

In https://github.com/eslint-community/eslint-plugin-eslint-comments/pull/18/, support for ESLint v4 and v5 was dropped (the intent per the PR). The change leaves only "peerDependencies": { "eslint": "^6.0.0 || ^7.0.0" }, so also dropped ESLint v8 support.

silverwind commented 11 months ago

Yep, can no longer install it on v8:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: undefined@undefined
npm ERR! Found: eslint@8.46.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"8.46.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^6.0.0 || ^7.0.0" from @eslint-community/eslint-plugin-eslint-comments@4.0.0
npm ERR! node_modules/@eslint-community/eslint-plugin-eslint-comments
npm ERR!   dev @eslint-community/eslint-plugin-eslint-comments@"4.0.0" from the root project
ota-meshi commented 11 months ago

@MichaelDeBoey This is the effect of change #18. It was still supposed to be an alpha release and v4 was supposed to contain the #20 changes, but #20 was closed and v4 was released first. We should merge #91 and open a pull request to support ESLint v8.

MichaelDeBoey commented 11 months ago

@aarongoldenthal @silverwind ESLint v8 was never officially supported (we had no tests for it), but indeed something that we should support asap as technically there are no changes needed to support it

github-actions[bot] commented 11 months ago

:tada: This issue has been resolved in version 4.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: