search

eslint-community / eslint-plugin-promise

Enforce best practices for JavaScript promises
ISC License
939 stars 91 forks source link

Swap release process to release-please #506

Closed voxpelli closed 1 month ago

voxpelli commented 1 month ago

I would personally be in favor of switching to a release please flow, like in https://github.com/eslint-community/eslint-plugin-n/pull/305, as that catches errors like this before release

This would help catch release errors like https://github.com/eslint-community/eslint-plugin-promise/issues/484#issuecomment-2247374199 before they actually get released

voxpelli commented 1 month ago

Thoughts @scagood @aladdin-add @brettz9?

brettz9 commented 1 month ago

Looks all right to me...

scagood commented 1 month ago

I do much prefer release-please as:

  1. It allows you to see the change logs in the PR description
  2. The package version is always correct in the package.json
  3. It allows for a more transparent release process

(Also, its just personal comfort :joy:)

It does have some down sides, such as merge commits occasionally create double entries in the change log.

ota-meshi commented 1 month ago

Between release-please and semantic-release, I personally prefer release-please. Because we can control the release timing.

voxpelli commented 1 month ago

It does have some down sides, such as merge commits occasionally create double entries in the change log.

Yeah, one should preferably only do squash (or rebase commits) with it

ota-meshi commented 1 month ago

Currently, it appears that only squash merging is allowed for this repository.

voxpelli commented 1 month ago

Currently, it appears that only squash merging is allowed for this repository.

That's good 👍