search

eslint-community / eslint-plugin-promise

Enforce best practices for JavaScript promises
ISC License
939 stars 91 forks source link

ci: swap release process to release-please #508

Closed voxpelli closed 1 month ago

voxpelli commented 1 month ago

What is the purpose of this pull request?

To improve the release process by swapping to release-please. Fixes #506

What changes did you make? (Give an overview)

Removed cycjimmy/semantic-release-action and added googleapis/release-please-action

ota-meshi commented 1 month ago

Do you think we also need to replace the version in package.json with "7.0.0"?

https://github.com/eslint-community/eslint-plugin-promise/blob/602d8254871e46c9d1808ee1a3a2c48cb7493334/package.json#L3

voxpelli commented 1 month ago

@ota-meshi Good point, fixed!

ota-meshi commented 1 month ago

The linting error should be fixed in #507.

voxpelli commented 1 month ago

I'm not familiar with the release-please config but it looks good to me. Thanks!

Its copied from eslint-plugin-n and neostandard :)

brettz9 commented 1 month ago

I'm not familiar with the release-please config but it looks good to me. Thanks!

Likewise...