eslint-community / eslint-plugin-promise

Enforce best practices for JavaScript promises
ISC License
939 stars 91 forks source link

ci: add pr title format validation #509

Closed voxpelli closed 1 month ago

voxpelli commented 1 month ago

What is the purpose of this pull request?

To assist #508 / #506 by ensuring that PR-title's are always valid conventional commit format before merging

What changes did you make? (Give an overview)

Added a pinned mtfoley/pr-compliance-action similar to what I use at eg. neostandard: https://github.com/neostandard/neostandard/blob/main/.github/workflows/compliance.yml

scagood commented 1 month ago

This may be better as a branch ruleset :thinking:

Then again, I dont know if this org is an 'Enterprise' org on github?

(This should be the link) https://github.com/eslint-community/eslint-plugin-promise/settings/rules/new?target=branch

Eg here is one in one of my repos: image

voxpelli commented 1 month ago

@scagood I believe that's only enforced in enterprise organizations

voxpelli commented 1 month ago

I added it to the ruleset now, but yeah, not enforced :)

Skärmavbild 2024-07-24 kl  16 24 08