eslint-community / eslint-plugin-promise

Enforce best practices for JavaScript promises
ISC License
939 stars 91 forks source link

chore(deps): switch from dependabot to renovate using shared eslint community configuration #537

Closed jerome-benoit closed 3 weeks ago

jerome-benoit commented 1 month ago

What is the purpose of this pull request?

Reduce dependencies management overhead.

What changes did you make? (Give an overview)

The post configuration on the repo needs an admin: https://github.com/renovatebot/renovate/blob/main/docs/usage/getting-started/installing-onboarding.md

voxpelli commented 4 weeks ago

Or do like eslint-plugin-n and move to Renovate: https://github.com/eslint-community/eslint-plugin-n/pull/44 (see dependency dashboard at https://github.com/eslint-community/eslint-plugin-n/issues/150)

This would be preferable I think, and we could eventually do a superset / alternative renovate config for eslint-community rather than just using the ESLint one directly, and that could be shared between eg. plugin-n and plugin-promise

jerome-benoit commented 4 weeks ago

The intent was to reduce the deps maintenance overhead with a minimum work and the current tooling: instead of having X PRs to review/merge, you now have 2 PRs maximum with the minimum sensible update semantic.

Changing the deps maintenance tooling for better one was not the scope.

voxpelli commented 4 weeks ago

Sure, but I would rather align across this and eg. eslint-plugin-n rather than have each do their own thing. Any downside to that?

jerome-benoit commented 4 weeks ago

The amount of work is not the same, at all.

And the two are not mutually exclusive:

voxpelli commented 4 weeks ago

Adding the same renovate config as eslint-plugin-n requires simply removing the dependabot config and adding a .github/renovate.json file with:

{
    "$schema": "https://docs.renovatebot.com/renovate-schema.json",
    "extends": ["github>eslint/eslint//.github/renovate.json5"]
}

It would take me mere minutes to do, but want opinions from eg. @brettz9 and @scagood before doing so

scagood commented 4 weeks ago

Adding the same renovate config as eslint-plugin-n requires simply removing the dependabot config and adding a .github/renovate.json file with:

{
    "$schema": "https://docs.renovatebot.com/renovate-schema.json",
    "extends": ["github>eslint/eslint//.github/renovate.json5"]
}

It would take me mere minutes to do, but want opinions from eg. @brettz9 and @scagood before doing so

Im in favour of copying the other community repos too :+1:

brettz9 commented 4 weeks ago

Haven't used Renovate personally, but no strong opinions about it either way.

(In my personal projects I like to just use npm-check-updates to periodically update dependencies locally, without any remote noise at all. :-) )

voxpelli commented 3 weeks ago

Merged, thanks @jerome-benoit 🙏

The original issue of the grouping is something we can revisit when we see how this works out 👍