search

eslint-community / eslint-utils

Utilities for ESLint plugins and custom rules.
https://eslint-community.github.io/eslint-utils
MIT License
18 stars 7 forks source link

Update semantic-release? #236

Open voxpelli opened 2 months ago

voxpelli commented 2 months ago

I noticed that we have pinned semantic-release to 19 in this repo:

https://github.com/eslint-community/eslint-utils/blob/ede67fea586f4369c47874a9f4cd660028136482/.github/workflows/ci.yml#L117

But the latest version is 24.1.1 at the time I create this issue.

Since the semantic-release version is neither defined through the uses: of the workflow or in devDependencies, we will get no update suggestions from Dependabot.

We should probably add it to devDependencies and skip the third party action in favor of the current suggested setup.

Either that or mimic https://github.com/eslint-community/eslint-plugin-promise/pull/508 / https://github.com/eslint-community/eslint-plugin-promise/pull/506 and switch to release-please.

Thoughts @MichaelDeBoey?

MichaelDeBoey commented 1 month ago

I would be in favor of simplifying the setup + use latest semantic-release

Switching towards release-please seems a bit unnecessary as semantic-release should support feat!:, but I wouldn't mind having it consistent either