CJS type declarations are not created

eslint-types / eslint-define-config

Provide a defineConfig function for .eslintrc.js files

MIT License

361 stars 26 forks source link

CJS type declarations are not created #282

Closed Lehoczky closed 7 months ago

Lehoczky commented 7 months ago

When dual-publishing libraries, CJS and MJS bundles must have different .d.ts files. Currently there is only type declaration file, which is for the MJS bundle.

Checked with:

https://arethetypeswrong.github.io/?p=eslint-define-config%402.1.0
https://publint.dev/eslint-define-config@2.1.0

PR is coming with the fix:)

Shinigami92 commented 7 months ago

These types are not required and it is just a warning that can be ignored. It only makes sense if the types differ from each other, but the emitted types are almost always the same and so would only double the bundle size.

So unless you proof me wrong, I would like to reject this PR.

Lehoczky commented 7 months ago

'Mkay for me!