Closed weihao closed 3 years ago
Hi @weihao!, thanks for the Pull Request
The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
The commit message tag must be one of the following:
The Tag
is one of the following:
You can use the labels of the issue you are working on to determine the best tag.
There should be a space following the initial tag and colon, for example 'New: Message'.
Read more about contributing to ESLint here
:heavy_check_mark: Deploy Preview for eslint ready!
:hammer: Explore the source changes: 8da06a6e8e9fe12b283d3b602ecf9dff57de3e5c
:mag: Inspect the deploy log: https://app.netlify.com/sites/eslint/deploys/60c42a97621ccc0007fbd28e
:sunglasses: Browse the preview: https://deploy-preview-854--eslint.netlify.app
it is a history version, and has been fixed the latest version. we usually do not change the history docs, but I think it's no harm to fix it.
Is the latest version deployed? I am seeing from the live site: https://eslint.org/docs/2.0.0/rules/semi#options
We can fix it, but really, no one should be using these old docs at this point. They are too far out of date. At some point we might just want to remove them.
@weihao in order to merge this, can you please sign our CLA?
Signed, thanks.
We can fix it, but really, no one should be using these old docs at this point. They are too far out of date. At some point we might just want to remove them.
This page was ranked first when my googled docs for eslint, so I thought it was relevant.
It is a great idea to remove them, however, until that happens, any error should be fixed.
@weihao do you remember what you searched for? And which Google site did you use?
@weihao do you remember what you searched for? And which Google site did you use?
google.com, searched for eslint semi
Very strange. I wonder if it’s related to the country you’re searching from because I’m not seeing any results for old ESLint versions.
I’ll dig into it more later.
Very strange. I wonder if it’s related to the country you’re searching from because I’m not seeing any results for old ESLint versions.
I’ll dig into it more later.
I dug around and found that I was searching for the meaning of 2 in semi: [2, 'never']
. so I think google associated '2' with version 2 of eslint in the context
Hi @weihao!, thanks for the Pull Request
The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
The commit message tag must be one of the following:
The
Tag
is one of the following:You can use the labels of the issue you are working on to determine the best tag.
There should be a space following the initial tag and colon, for example 'New: Message'.
Read more about contributing to ESLint here