search

eslint / archive-website

The ESLint website
https://eslint.org
MIT License
95 stars 244 forks source link

Docs: Display emoji/notice for rules with suggestions #860

Closed bmish closed 3 years ago

bmish commented 3 years ago

Fixes #859.

Other part required for this change: https://github.com/eslint/eslint/pull/14830

netlify[bot] commented 3 years ago

✔️ Deploy Preview for eslint ready!

🔨 Explore the source changes: b6ceb5f8bae95c6524f2229b7a2136a6de58ddf4

🔍 Inspect the deploy log: https://app.netlify.com/sites/eslint/deploys/6102ee861ea44e00079f58d5

😎 Browse the preview: https://deploy-preview-860--eslint.netlify.app/docs/rules

nzakas commented 3 years ago

Force-pushing seems to be messing up the deploy preview. There’s no need to force-push, you can keep adding new commits. We only check the first commit message so the pressure is off. :)

can you try adding a new commit to see if it triggers the deploy preview to regenerate?

bmish commented 3 years ago

Will rules.yml get automatically regenerated at some point? I manually updated the relevant parts.

mdjermanovic commented 3 years ago

Will rules.yml get automatically regenerated at some point? I manually updated the relevant parts.

Yes, it gets updated on each ESLint release. (not including prereleases)

mdjermanovic commented 3 years ago

Preview LGTM!

Note about merging: If we want to merge this after we merge https://github.com/eslint/eslint/pull/14830 and do the release, then we should undo the changes in _data/rules.yml. Otherwise, it will produce an invalid yml with duplicate keys.

bmish commented 3 years ago

Sounds good. Just reverted _data/rules.yml. Mind re-approving / merging?