eslint / archive-website

The ESLint website
https://eslint.org
MIT License
95 stars 244 forks source link

docs: Adding canonical links #885

Closed thomasgilmore closed 2 years ago

thomasgilmore commented 2 years ago

Adding canonical links to blog posts. This pull request solves issue #568

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

netlify[bot] commented 2 years ago

โœ”๏ธ Deploy Preview for eslint ready!

๐Ÿ”จ Explore the source changes: b449ef5f51b39cdcfbf25b5e56629db48b66082e

๐Ÿ” Inspect the deploy log: https://app.netlify.com/sites/eslint/deploys/6184ac7e9f17fb0007aa293a

๐Ÿ˜Ž Browse the preview: https://deploy-preview-885--eslint.netlify.app/blog/2021/11/the-inception-of-eslint

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

thomasgilmore commented 2 years ago

@nzakas I'm not sure how to fix the commit message error. I've changed the PR Title and changed the commit message. I think I'm missing something.

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

aladdin-add commented 2 years ago

@thomasgilmore95 we have started to use the conventional commits. https://eslint.org/docs/developer-guide/contributing/pull-requests#step-2-make-your-changes

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

eslint-github-bot[bot] commented 2 years ago

Hi @thomasgilmore95!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

Read more about contributing to ESLint here

aladdin-add commented 2 years ago

no worries, I've fixed the title.

thomasgilmore commented 2 years ago

@aladdin-add thank you

thomasgilmore commented 2 years ago

I added the gist blog post to see it in deploy preview.

nzakas commented 2 years ago

Looks like it's not working: https://deploy-preview-885--eslint.netlify.app/blog/2018/02/the-inception-of-eslint

The canonical URL isn't the original URL.

thomasgilmore commented 2 years ago

I tested the canonical url and it comes back href(unknown). I made a commit so you could see it as well.

thomasgilmore commented 2 years ago

Is there another way to access the page's front matter variables.

nzakas commented 2 years ago

I donโ€™t know Eleventy well enough to answer that. Iโ€™d suggest checking the docs: https://www.11ty.dev/docs/data-frontmatter/

thomasgilmore commented 2 years ago

Thank you that link was helpful. The canonical link is being show know if original is present.

thomasgilmore commented 2 years ago

Please let me know if you want me to make any changes.

thomasgilmore commented 2 years ago

Thank you for letting me work on this.