search

eslint / archive-website

The ESLint website
https://eslint.org
MIT License
96 stars 244 forks source link

chore: Changes to support static frontmatter in docs #933

Closed nzakas closed 2 years ago

nzakas commented 2 years ago

Updated website templates to us the static frontmatter in the docs files (https://github.com/eslint/eslint/pull/15782).

Changes include:

netlify[bot] commented 2 years ago

Deploy Preview for eslint ready!

Name Link
Latest commit f8b048ce9a984a833e33e113bf3bb483ca88c7f8
Latest deploy log https://app.netlify.com/sites/eslint/deploys/62572ce8ceef1900090c21a7
Deploy Preview https://deploy-preview-933--eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for eslint ready!

Name Link
Latest commit 24db6456f273ff294f0779d541cb89064e839351
Latest deploy log https://app.netlify.com/sites/eslint/deploys/62602cf6c92f0e000818b8bb
Deploy Preview https://deploy-preview-933--eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mdjermanovic commented 2 years ago

If we want to add docs/developer-guide/architecture/index.md, we should remove docs/developer-guide/architecture.md file in this repository to allow access to https://eslint.org/docs/developer-guide/architecture/

(when there's a foo/bar.html file, Netlify redirects foo/bar/ to foo/bar even if foo/bar/index.html exists).

Step 2 in Makefile.js is actually not removing anything from the website. It looks like it expects a list of files, but gets a list of directories.

nzakas commented 2 years ago

If we want to add docs/developer-guide/architecture/index.md, we should remove docs/developer-guide/architecture.md file in this repository

Could have sworn I did that but maybe didn’t make it into the last commit.

nzakas commented 2 years ago

It looks like the website is now dependent on Makefile.js not removing old files (I tried fixing it but it introduced a bunch of errors due to files that live in website but aren't present in eslint). So, we should just leave that as-is until the new docs site is up and running, at which point we can remove all of that logic.