search

eslint / archive-website

The ESLint website
https://eslint.org
MIT License
96 stars 244 forks source link

fix: check if blog post authors are specified in fetch-team-data script #934

Closed mdjermanovic closed 2 years ago

mdjermanovic commented 2 years ago

The fetch-team-data.js script is failing with the following error:

TypeError: frontmatter.authors is not iterable

(check on Jenkins)

I updated one blog post that didn't have authors, but that alone doesn't help because we're running the fetch script right after the release, and at that point there's a newly created release post without authors. Therefore, I also updated the script to check if authors exists.

I tested this locally and it works well, but I didn't commit the change in team.json so that the Jenkins job could update the team info both on the website and the README.md in eslint/eslint after the next release.

netlify[bot] commented 2 years ago

Deploy Preview for eslint ready!

Name Link
Latest commit d831532bbdfec7c2ab77dfab0a9ad91c00089a50
Latest deploy log https://app.netlify.com/sites/eslint/deploys/625b66f31869d40008c79cbe
Deploy Preview https://deploy-preview-934--eslint.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

snitin315 commented 2 years ago

Created https://github.com/eslint/new.eslint.org/pull/192 for https://new.eslint.org