Closed AddisonG closed 2 years ago
Hi @AddisonG!, thanks for the Pull Request
The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by running git commit --amend
, editing your commit message, and then running git push -f
to update this pull request.
Read more about contributing to ESLint here
Name | Link |
---|---|
Latest commit | 4802981d97eb22e2813182a43d227460ef13ceb7 |
Latest deploy log | https://app.netlify.com/sites/eslint/deploys/6268cf5301d11700081aae0a |
Deploy Preview | https://deploy-preview-937--eslint.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Thanks! This looks good to me.
Thanks! The source for this documentation is actually here: https://github.com/eslint/eslint/blob/main/docs/src/rules/no-constant-binary-expression.md
Merging this will only affect the live site, but it will be overwritten when we do the next release. Please be sure to update the original file too.
Thanks @nzakas - I already did the other one, but wasn't sure if I should do this.
Ah ok. We can merge this to fix it on the live site.
The example here wrongly used
x
instead ofa
.