search

eslint / eslint-github-bot

Plugin-based GitHub bot for ESLint
MIT License
64 stars 20 forks source link

Bug: bot comments/adds auto closed label to already closed issues #110

Open kaicataldo opened 5 years ago

kaicataldo commented 5 years ago

It looks like the bot is adding the auto closed label and commenting on issues that are already closed. See https://github.com/eslint/eslint/issues/11859.

anikethsaha commented 4 years ago

I think this has been fixed? ( here, here, here )

Also I can see few issues that should have the label if this bug is still there. like this one https://github.com/eslint/eslint/issues/13352

nzakas commented 4 years ago

I wonder if this is just a timing issue? We are definitely only searching for open issues so maybe there was some kind of lag as to when the issue was marked as closed in the search meta data on GitHub?

anikethsaha commented 4 years ago

I did check some of the newly closed issues that were not closed due to inactivity. I was not able to notice this issue.

kaicataldo commented 4 years ago

I wonder if this is just a timing issue? We are definitely only searching for open issues so maybe there was some kind of lag as to when the issue was marked as closed in the search meta data on GitHub?

That makes sense. If this is the case and it's not happening often, I don't think it's worth trying to fix.