eslint / eslint-release

The ESLint release tool
Other
24 stars 11 forks source link

Changelog generation fails on newer versions of git #15

Closed not-an-aardvark closed 7 years ago

not-an-aardvark commented 7 years ago

Since Git 2.11, commit shorthashes are sometimes longer than 7 characters. Since we use a regex that expects exactly 7 characters in the hashes, no changelogs are generated when using newer versions of git. This caused some problems in today's eslint release.

The short-term solution would be to loosen the regex so that it can accept more than 7 characters. In the long term, maybe we should top using a regex to parse commit info at all (since git already provides format strings to get arbitrary pieces of info from a commit).