eslint / eslint-release

The ESLint release tool
Other
24 stars 11 forks source link

Fix: gracefully handle shorthashes longer than 7 characters (fixes #15) #16

Closed not-an-aardvark closed 7 years ago

not-an-aardvark commented 7 years ago

This updates the changelog generator to gracefully handle commit hashes longer than 7 characters. Long shorthashes like this can be produced by newer versions of git when working with a large repository. Previously, the release tool would skip any commits with long hashes (resulting in an empty changelog).

With this implementation, the long shorthashes will be included in the changelog rather than being truncated. One disadvantage of doing it this way is that the changelog might be inconsistent -- it could vary between 7-character and 8-character shorthashes depending on the version of git installed on the release machine. However, this does reduce the risk of generating broken links due to ambiguous commit hashes, which is the whole point of having longer shorthashes anyway.

Fixes https://github.com/eslint/eslint-release/issues/15