search

eslint / eslint-release

The ESLint release tool
Other
24 stars 11 forks source link

Breaking: require node >= 8.0 & upgrade eslint-config-eslint #34

Closed aladdin-add closed 5 years ago

aladdin-add commented 5 years ago
kaicataldo commented 5 years ago

Friendly ping 👋 . Do we want to try to land this still?

platinumazure commented 5 years ago

@kaicataldo I had a concern about an // eslint-disable-line with no rules listed, which I was hoping would be addressed but it doesn't seem to be addressed yet.

@aladdin-add Am I missing anything?

kaicataldo commented 5 years ago

I also think it's a good practice to be explicit about what rules are being disabled. :+1:

aladdin-add commented 5 years ago

oops, sorry. I missed it somehow, will update it later

aladdin-add commented 5 years ago

just updated to require Node.js >=8, as Node.js v6 has been EOL.