search

eslint / eslint-release

The ESLint release tool
Other
24 stars 11 forks source link

Update: Remove specific branch from git push (fixes #42) #43

Closed nzakas closed 4 years ago

nzakas commented 4 years ago

This removes the origin master part of the git push command during a release. This should allow us to use the current branch instead of always master, which will facilitate the change over to using main as the primary branch.

kaicataldo commented 4 years ago

Tangentially, should this be a breaking change? Trying to think of what downsides might exist to pushing a branch that isn't called master to a remote and am not coming up with anything...

nzakas commented 4 years ago

Git automatically pushes to origin and automatically matches the branch to the current one, so in theory this should not be a breaking change.

nzakas commented 4 years ago

Did a release with this and it worked! https://github.com/eslint/eslint-release/releases/tag/v3.1.0

:tada: