chore: Add Powered by Algolia label to the search - Githubissues

eslint / eslint.org

ESLint website

Apache License 2.0

74 stars 62 forks source link

chore: Add Powered by Algolia label to the search #595

Closed amareshsm closed 2 months ago

amareshsm commented 3 months ago

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request?

Add Powered by Algolia label to the search

What changes did you make? (Give an overview)

Added powered by Algolia label under the search box

Related Issues

https://github.com/eslint/eslint/issues/18620

Is there anything you'd like reviewers to focus on?

Need to verify that the changes work correctly across all device screen sizes.

netlify[bot] commented 3 months ago

Deploy Preview for es-eslint ready!

Name	Link
Latest commit	91470f2ac37517f53dd48f294beeaf65b0e01de3
Latest deploy log	https://app.netlify.com/sites/es-eslint/deploys/6686f402d937750008e78953
Deploy Preview	https://deploy-preview-595--es-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for ja-eslint ready!

Name	Link
Latest commit	91470f2ac37517f53dd48f294beeaf65b0e01de3
Latest deploy log	https://app.netlify.com/sites/ja-eslint/deploys/6686f40282deb600083191d7
Deploy Preview	https://deploy-preview-595--ja-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for new-eslint ready!

Name	Link
Latest commit	91470f2ac37517f53dd48f294beeaf65b0e01de3
Latest deploy log	https://app.netlify.com/sites/new-eslint/deploys/6686f4021c7f2c0009fb1a43
Deploy Preview	https://deploy-preview-595--new-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for zh-hans-eslint ready!

Name	Link
Latest commit	91470f2ac37517f53dd48f294beeaf65b0e01de3
Latest deploy log	https://app.netlify.com/sites/zh-hans-eslint/deploys/6686f4024e9dfc000982bde7
Deploy Preview	https://deploy-preview-595--zh-hans-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for fr-eslint ready!

Name	Link
Latest commit	91470f2ac37517f53dd48f294beeaf65b0e01de3
Latest deploy log	https://app.netlify.com/sites/fr-eslint/deploys/6686f40221664a000827a27f
Deploy Preview	https://deploy-preview-595--fr-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for hi-eslint ready!

Name	Link
Latest commit	91470f2ac37517f53dd48f294beeaf65b0e01de3
Latest deploy log	https://app.netlify.com/sites/hi-eslint/deploys/6686f402568d0700086fe819
Deploy Preview	https://deploy-preview-595--hi-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for de-eslint ready!

Name	Link
Latest commit	91470f2ac37517f53dd48f294beeaf65b0e01de3
Latest deploy log	https://app.netlify.com/sites/de-eslint/deploys/6686f40220d01300083e5929
Deploy Preview	https://deploy-preview-595--de-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for pt-br-eslint ready!

Name	Link
Latest commit	91470f2ac37517f53dd48f294beeaf65b0e01de3
Latest deploy log	https://app.netlify.com/sites/pt-br-eslint/deploys/6686f402fe2aa600075a0d8a
Deploy Preview	https://deploy-preview-595--pt-br-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nzakas commented 3 months ago

Screenshot 2024-06-28 at 17-05-19 News and Updates - ESLint - Pluggable JavaScript Linter

Feedback:

The color of the Algolia logo and text looks pretty bad in both light and dark themes. Can we just have it be the same color as the "Powered by"?
The baseline of the word "Algolia" is slightly higher than "Powered by", making it look broken. Can we get that baseline to match?

nzakas commented 2 months ago

@amareshsm are you still working on this? If not, I can take it over. We'd like to get this updated and published ASAP.

amareshsm commented 2 months ago

Feedback:

The color of the Algolia logo and text looks pretty bad in both light and dark themes. Can we just have it be the same color as the "Powered by"?

The baseline of the word "Algolia" is slightly higher than "Powered by", making it look broken. Can we get that baseline to match?

changes done. I have updated the description with the latest screenshots.