search

eslint / eslint.org

ESLint website
Apache License 2.0
77 stars 63 forks source link

Bug: Alignment of search bar cancel icon on the documentation page is broken #606

Closed zaryanz closed 3 months ago

zaryanz commented 3 months ago

URL(s)

https://eslint.org/docs/latest/

What did you do?

This bug can be reproduced by searching for something in the search bar. Tested on Firefox 128.0.2 (64-bit), Google Chrome 126.0.6478.183 (Official Build) (arm64) - macOS Ventura 13.3.1

What did you expect to happen?

Ideally, the cancel icon should be center aligned.

What actually happened?

Currently, the cancel icon appears at the bottom of the search bar, which does not look right.

Screenshot 2024-07-25 at 12 45 23 PM

Participation

Additional comments

No response

harish-sethuraman commented 3 months ago

Can you send similar fixes as https://github.com/eslint/eslint/pull/18682/files?

zaryanz commented 3 months ago

Sure thing. Thanks for providing the reference! I'll be raising a PR for the same shortly.

amareshsm commented 3 months ago

@zaryanz Thanks for pointing out the issue. It has already been fixed in https://github.com/eslint/eslint.org/pull/603 but it hasn't been deployed yet.