fix: style issues in no-js mode - Githubissues

eslint / eslint.org

ESLint website

Apache License 2.0

74 stars 62 forks source link

fix: style issues in no-js mode #628

Open Tanujkanti4441 opened 1 week ago

Tanujkanti4441 commented 1 week ago

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request?

There are some styles that are different in no-js mode as compared enabled javascript mode.

What changes did you make? (Give an overview)

This PR fixes following style in no-js mode.

JavaScript Enabled	JavaScript Disabled

Related Issues

Is there anything you'd like reviewers to focus on?

netlify[bot] commented 1 week ago

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name	Link
Latest commit	8fad8118ddccbbe23414b794c5a22f00c286eabb
Latest deploy log	https://app.netlify.com/sites/new-eslint/deploys/66f1550282dad500086f5d64
Deploy Preview	https://deploy-preview-628--new-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for hi-eslint ready!

Name	Link
Latest commit	8fad8118ddccbbe23414b794c5a22f00c286eabb
Latest deploy log	https://app.netlify.com/sites/hi-eslint/deploys/66f155021ac82300083a1582
Deploy Preview	https://deploy-preview-628--hi-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for es-eslint ready!

Name	Link
Latest commit	8fad8118ddccbbe23414b794c5a22f00c286eabb
Latest deploy log	https://app.netlify.com/sites/es-eslint/deploys/66f15502701eb700083dbaab
Deploy Preview	https://deploy-preview-628--es-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for fr-eslint ready!

Name	Link
Latest commit	8fad8118ddccbbe23414b794c5a22f00c286eabb
Latest deploy log	https://app.netlify.com/sites/fr-eslint/deploys/66f155020d5aee000824fa5b
Deploy Preview	https://deploy-preview-628--fr-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for ja-eslint ready!

Name	Link
Latest commit	8fad8118ddccbbe23414b794c5a22f00c286eabb
Latest deploy log	https://app.netlify.com/sites/ja-eslint/deploys/66f15502cc677900084ce006
Deploy Preview	https://deploy-preview-628--ja-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for zh-hans-eslint ready!

Name	Link
Latest commit	8fad8118ddccbbe23414b794c5a22f00c286eabb
Latest deploy log	https://app.netlify.com/sites/zh-hans-eslint/deploys/66f1550291855b0008bc36f4
Deploy Preview	https://deploy-preview-628--zh-hans-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for de-eslint ready!

Name	Link
Latest commit	8fad8118ddccbbe23414b794c5a22f00c286eabb
Latest deploy log	https://app.netlify.com/sites/de-eslint/deploys/66f15502b0b2b50008b581f0
Deploy Preview	https://deploy-preview-628--de-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for pt-br-eslint ready!

Name	Link
Latest commit	8fad8118ddccbbe23414b794c5a22f00c286eabb
Latest deploy log	https://app.netlify.com/sites/pt-br-eslint/deploys/66f155025dc2f80008fdf6a2
Deploy Preview	https://deploy-preview-628--pt-br-eslint.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

amareshsm commented 1 week ago

A few issues still need to be addressed:

On the donation page, the GitHub company logo is not visible in the "Ways to Sponsor" section when using dark theme in no-JS mode.

Need to correct the styling for the code blocks.

Tanujkanti4441 commented 3 days ago

In the light theme ESLint logo is not visible

I could not reproduce this, can you please share if it is in js or no-js mode, or any steps to reproduce?

amareshsm commented 2 days ago

In the light theme ESLint logo is not visible

I could not reproduce this, can you please share if it is in js or no-js mode, or any steps to reproduce?

I can reproduce this issue locally. you can check this preview link in the no-js mode light theme the ESlint logo is not visible.