Closed renovate[bot] closed 6 months ago
netlify[bot]
commented
6 months ago | Name | Link |
|---|---|
| Latest commit | 1d08df9f65c145ae749026b1d955fda0ad7f4b93 |
| Latest deploy log | https://app.netlify.com/sites/docs-eslint/deploys/654d019862e345000865e8c3 |
snitin315
commented
6 months ago markdown-lint can't be upgraded to the latest version right now as it requires node >=18. This project doesn't seem to follow semantic versioning.
Should we close the PR?
mdjermanovic
commented
6 months ago markdown-lint can't be upgraded to the latest version right now as it requires node >=18. This project doesn't seem to follow semantic versioning.
I believe the semver rules are different for major version zero - anything can change in any version, though it's common practice that breaking changes bump the minor version, which is the case here.
Should we close the PR?
We already have some dev dependencies that require a higher version of Node.js than ESLint, and requirements for the development environment don't necessarily need to be the same as for the released package, so I think we could update markdownlint. The problem here is that in Makefile.js we require() most dependencies at the top, so when we run node Makefile mocha it loads markdownlint although this operation doesn't use it, and markdownlint happens to crash right away while loading on older versions of Node.js. I believe the problem can be solved by moving require("markdownlint") into function lintMarkdown. The question is whether it is worth the effort at this point, though it might be good to reduce Makefile's loading time anyway.
snitin315
commented
6 months ago @mdjermanovic Yes, you're right. Upgraded it in https://github.com/eslint/eslint/pull/17754
This PR contains the following updates:
^0.25.1->^0.31.0Release Notes
DavidAnson/markdownlint (markdownlint)
### [`v0.31.1`](https://togithub.com/DavidAnson/markdownlint/blob/HEAD/CHANGELOG.md#0311) [Compare Source](https://togithub.com/DavidAnson/markdownlint/compare/v0.31.0...v0.31.1) - Improve MD032/MD034 - Update dependencies ### [`v0.31.0`](https://togithub.com/DavidAnson/markdownlint/blob/HEAD/CHANGELOG.md#0310) [Compare Source](https://togithub.com/DavidAnson/markdownlint/compare/v0.30.0...v0.31.0) - Improve MD032/MD037/MD043/MD044/MD051/MD052 - Improve performance - Update dependencies ### [`v0.30.0`](https://togithub.com/DavidAnson/markdownlint/blob/HEAD/CHANGELOG.md#0300) [Compare Source](https://togithub.com/DavidAnson/markdownlint/compare/v0.29.0...v0.30.0) - Use `micromark` in MD022/MD026/MD032/MD037/MD045/MD051 - Incorporate `micromark-extension-math` for math syntax - Allow custom rules to override information URL - Update dependencies ### [`v0.29.0`](https://togithub.com/DavidAnson/markdownlint/blob/HEAD/CHANGELOG.md#0290) [Compare Source](https://togithub.com/DavidAnson/markdownlint/compare/v0.28.2...v0.29.0) - Update `micromark` parser dependencies for better performance - Use `micromark` in MD049/MD050 - Improve MD034/MD037/MD044/MD049/MD050 - Support multiple parsers in demo page - Remove support for end-of-life Node version 14 - Update dependencies ### [`v0.28.2`](https://togithub.com/DavidAnson/markdownlint/blob/HEAD/CHANGELOG.md#0282) [Compare Source](https://togithub.com/DavidAnson/markdownlint/compare/v0.28.1...v0.28.2) - Update dependencies for CVE-2023-2251 ### [`v0.28.1`](https://togithub.com/DavidAnson/markdownlint/blob/HEAD/CHANGELOG.md#0281) [Compare Source](https://togithub.com/DavidAnson/markdownlint/compare/v0.28.0...v0.28.1) - Update dependencies ### [`v0.28.0`](https://togithub.com/DavidAnson/markdownlint/blob/HEAD/CHANGELOG.md#0280) [Compare Source](https://togithub.com/DavidAnson/markdownlint/compare/v0.27.0...v0.28.0) - Introduce `micromark` parser for better positional data (internal only) - Use `micromark` in MD013/MD033/MD034/MD035/MD038/MD044/MD052/MD053 - Simplify file-based test cases - Unify browser script for demo page - Update dependencies ### [`v0.27.0`](https://togithub.com/DavidAnson/markdownlint/blob/HEAD/CHANGELOG.md#0270) [Compare Source](https://togithub.com/DavidAnson/markdownlint/compare/v0.26.2...v0.27.0) - Improve MD011/MD013/MD022/MD031/MD032/MD033/MD034/MD040/MD043/MD051/MD053 - Generate/separate documentation - Improve documentation - Update dependencies ### [`v0.26.2`](https://togithub.com/DavidAnson/markdownlint/blob/HEAD/CHANGELOG.md#0262) [Compare Source](https://togithub.com/DavidAnson/markdownlint/compare/v0.26.1...v0.26.2) - Improve MD037/MD051/MD053 ### [`v0.26.1`](https://togithub.com/DavidAnson/markdownlint/blob/HEAD/CHANGELOG.md#0261) [Compare Source](https://togithub.com/DavidAnson/markdownlint/compare/v0.26.0...v0.26.1) - Improve MD051 ### [`v0.26.0`](https://togithub.com/DavidAnson/markdownlint/blob/HEAD/CHANGELOG.md#0260) [Compare Source](https://togithub.com/DavidAnson/markdownlint/compare/v0.25.1...v0.26.0) - Add MD051/MD052/MD053 for validating link fragments & reference links/images & link/image reference definitions (MD053 auto-fixable) - Improve MD010/MD031/MD035/MD039/MD042/MD044/MD049/MD050 - Add `markdownlint-disable-line` inline comment - Support `~` paths in `readConfig/Sync` - Add `configParsers` option - Remove support for end-of-life Node version 12 - Default `resultVersion` to 3 - Update browser script to use ES2015 - Simplify JSON schema - Address remaining CodeQL issues - Improve performance - Update dependenciesConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.