eslint / eslint

Find and fix problems in your JavaScript code.
https://eslint.org
MIT License
24.39k stars 4.4k forks source link

chore: remove eslintrc export from eslint-config-eslint #18400

Closed mdjermanovic closed 3 weeks ago

mdjermanovic commented 3 weeks ago

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update [ ] Bug fix (template) [ ] New rule (template) [ ] Changes an existing rule (template) [ ] Add autofix to a rule [ ] Add a CLI option [ ] Add something to the core [x] Other, please explain:

Removes eslintrc export from eslint-config-eslint so that we can publish v10 without it.

What changes did you make? (Give an overview)

  1. Copied the content of packages/eslint-config-eslint/eslintrc.js directly into the root .eslintrc.js.
  2. Removed packages/eslint-config-eslint/eslintrc.js file and the corresponding export from packages/eslint-config-eslint/package.json.
  3. Also made a few updates to make this project lint-free when linted using .eslintrc.js.

Is there anything you'd like reviewers to focus on?

netlify[bot] commented 3 weeks ago

Deploy Preview for docs-eslint canceled.

Name Link
Latest commit f67403a0b4c6fb8f484f0289c10a3daa576133d9
Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/662b86f15ff0600009408114
mdjermanovic commented 3 weeks ago

I'm not sure why knip now considers eslint-config-eslint being unused.

aladdin-add commented 2 weeks ago

@mdjermanovic it has been merged, ready to release eslint-config-eslint v10. 😄