eslint / eslint

Find and fix problems in your JavaScript code.
https://eslint.org
MIT License
24.39k stars 4.4k forks source link

fix: improve message for ignored files without a matching config #18404

Open fasttime opened 2 weeks ago

fasttime commented 2 weeks ago

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update [X] Bug fix (template) [ ] New rule (template) [ ] Changes an existing rule (template) [ ] Add autofix to a rule [ ] Add a CLI option [ ] Add something to the core [ ] Other, please explain:

Fixes #18263

What changes did you make? (Give an overview)

Extended createIgnoreResult with an additional parameter that indicates whether a file has a matching configuration, in order to provide a better message when this is not the case. The value passed with this parameter is retrieved directly from ConfigArray, which got a new method isFileConfigured for this purpose. See the PR in config-array: https://github.com/humanwhocodes/config-array/pull/138.

Is there anything you'd like reviewers to focus on?

netlify[bot] commented 2 weeks ago

Deploy Preview for docs-eslint canceled.

Name Link
Latest commit d15c087ca40908678c8eb02ccfecde9e21e0b17b
Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6631da5bf47fe00007847464
github-actions[bot] commented 1 week ago

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

fasttime commented 6 days ago

Still working on this.