eslint / eslint

Find and fix problems in your JavaScript code.
https://eslint.org
MIT License
24.44k stars 4.41k forks source link

fix: Improve config error messages #18457

Closed nzakas closed 2 weeks ago

nzakas commented 2 weeks ago

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update [ ] Bug fix (template) [ ] New rule (template) [ ] Changes an existing rule (template) [ ] Add autofix to a rule [ ] Add a CLI option [x] Add something to the core [ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

netlify[bot] commented 2 weeks ago

Deploy Preview for docs-eslint canceled.

Name Link
Latest commit a30a8e46056f573919cfd7b63bf299b20f78111b
Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6644cfed6476d5000823095d
nzakas commented 2 weeks ago

@aladdin-add I don't understand why you're suggesting to change the wording in all of the messages. I purposely used "You" to make it clear to people that if they, personally, aren't using the key then it's probably coming from a plugin.

aladdin-add commented 2 weeks ago

well. I don't feel strong about the wording - just want to say it's also may be coming from a shared config. 😄